Bug 501153

Summary: Brushes preview affected by mirror settings
Product: [Applications] krita Reporter: keyth_qcfx2 <keyth2363214>
Component: Brush enginesAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: scottpetrovic
Priority: NOR    
Version First Reported In: 5.2.9   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://invent.kde.org/graphics/krita/-/commit/7f11c4551b63187e8165153fa78b36addc8ad633 Version Fixed In:
Sentry Crash Report:

Description keyth_qcfx2 2025-03-06 17:40:09 UTC 
SUMMARY
Activating brush horizontal or vertical mirror the edit brush settings is affected on it's preview.

STEPS TO REPRODUCE
1. activate "horizontal mirror tool" or "vertical mirror tool"
2. open the "edit brush settings"
3. brush preview will be affected ( only updated when opening the settings )

OBSERVED RESULT
brush preview is painting with the mirror tools active

EXPECTED RESULT
rendering the brush preview without optional canvas settings like horizontal or vertical mirror

SOFTWARE/OS VERSIONS
Windows: 10
Qt Version: 5.12

ADDITIONAL INFORMATION
preview of the bug
https://krita-artists.org/uploads/default/original/3X/9/f/9f83fc21cfa104a144ed0c141e7d978304a5737e.png
https://krita-artists.org/uploads/default/original/3X/d/a/dab3b341651ed9a50cd479b73a997a2c568f0567.gif
Comment 1 Scott Petrovic 2025-04-02 12:51:26 UTC 
I can confirm this on the master branch on Windows. That is something I didn't even think to test. I am guessing when the previews are being created, they can just temporarily turn off any of those mirrror settings if they are on.
Comment 2 Scott Petrovic 2025-04-02 16:13:48 UTC 
There is a merge request to fix this. We can close this whenever it gets merged to master. https://invent.kde.org/graphics/krita/-/merge_requests/2365
Comment 3 Dmitry Kazakov 2025-04-07 13:27:06 UTC 
Git commit 25bdf8153654da4bf75cb5a882d85577c8cf6ff6 by Dmitry Kazakov, on behalf of Scott Petrovic.
Committed on 07/04/2025 at 13:26.
Pushed by dkazakov into branch 'master'.

M  +6    -0    libs/ui/tool/kis_resources_snapshot.cpp
M  +1    -0    libs/ui/tool/kis_resources_snapshot.h
M  +1    -0    libs/ui/widgets/kis_preset_live_preview_view.cpp

https://invent.kde.org/graphics/krita/-/commit/25bdf8153654da4bf75cb5a882d85577c8cf6ff6
Comment 4 Dmitry Kazakov 2025-04-07 13:27:31 UTC 
Git commit 7f11c4551b63187e8165153fa78b36addc8ad633 by Dmitry Kazakov.
Committed on 07/04/2025 at 13:27.
Pushed by dkazakov into branch 'krita/5.2'.


(cherry picked from commit 25bdf8153654da4bf75cb5a882d85577c8cf6ff6)

Co-authored-by: Scott Petrovic <scottpetrovic@gmail.com>

M  +6    -0    libs/ui/tool/kis_resources_snapshot.cpp
M  +1    -0    libs/ui/tool/kis_resources_snapshot.h
M  +1    -0    libs/ui/widgets/kis_preset_live_preview_view.cpp

https://invent.kde.org/graphics/krita/-/commit/7f11c4551b63187e8165153fa78b36addc8ad633