Bug 50099

Summary:	Post - sign with GPG - cancel -> post is sent without sign, should go back to edit
Product:	[Unmaintained] knode	Reporter:	Rui Malheiro <rui.m.malheiro>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	n-roeser
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	RedHat Enterprise Linux
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Hannu Kotipalo 2002-11-03 12:31:42 UTC

Version:            (using KDE KDE 3.0.4)
Installed from:    RedHat RPMs
OS:          Linux

When I sign a post, see preview and press cancel, the post is sent unsigned without notice. It should go back to editing the message.

Comment 1 Rui Malheiro 2003-12-28 21:23:54 UTC

I submited a duplicate of this bug.  Can someone mark Bug 67108  as a duplicate of this one?

And by the way, I'm using KDE 3.2 beta (CVS >20031206)

Comment 2 Volker Krause 2003-12-30 13:55:07 UTC

*** Bug 67108 has been marked as a duplicate of this bug. ***

Comment 3 n-roeser 2004-03-09 19:23:53 UTC

I can confirm this with kde-3.2.0 (final).

Comment 4 Stephan Kulow 2004-05-27 10:10:55 UTC

Replaced hannu.kotipalo@iki.fi with rmalheiro@6mil.pt due to bounces by reporter

Comment 5 Rui Malheiro 2004-07-01 11:47:42 UTC

This bug still applies to KDE 3.2.3

Comment 6 Volker Krause 2004-07-04 14:53:39 UTC

CVS commit by vkrause: 

Switch back to the composer if the user cancels the GPG signing instead of silently sending the article without signing.

CCMAIL: 50099-done@bugs.kde.org


  M +4 -0      knarticlefactory.cpp   1.76
  M +2 -2      kncomposer.cpp   1.198


--- kdepim/knode/knarticlefactory.cpp  #1.75:1.76
@@ -1013,4 +1013,6 @@ void KNArticleFactory::slotComposerDone(
         if ( com->applyChanges() )
           sendArticles(&lst, true);
+        else
+          delCom = false;
       }
     break;
@@ -1021,4 +1023,6 @@ void KNArticleFactory::slotComposerDone(
         if ( com->applyChanges() )
           sendArticles(&lst, false);
+        else
+          delCom = false;
       }
     break;

--- kdepim/knode/kncomposer.cpp  #1.197:1.198
@@ -58,5 +58,4 @@ using KRecentAddress::RecentAddresses;
 #include "knaccountmanager.h"
 #include "knnntpaccount.h"
-#include <kpgp.h>
 #include "knarticlefactory.h"
 #include <kstatusbar.h>
@@ -64,5 +63,4 @@ using KRecentAddress::RecentAddresses;
 #include <qpopupmenu.h>
 #include <spellingfilter.h>
-#include <qcursor.h>
 #include <kstdguiitem.h>
 
@@ -844,4 +842,6 @@ bool KNComposer::applyChanges()
               QCString result = block.text();
               tmp = codec->toUnicode(result.data(), result.length() );
+          } else {
+              return false;
           }
       }