| Summary: | "Update" entry in left-hand list should be "Updates" | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | John Veness <john.kde> |
| Component: | discover | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aleixpol, nate, sitter |
| Priority: | NOR | ||
| Version First Reported In: | 6.3.2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/discover/-/commit/bfd8fbf6db8ce167d90c3abd0c05f98a84e02387 | Version Fixed In: | 6.4.0 |
| Sentry Crash Report: | |||
| Attachments: |
Discover Update/Updates screenshot
Discover showing "Update" when multiple updates in en_GB |
||
This should be easy! We'll just have to find the place in the code where string is. I'm guessing it's https://invent.kde.org/plasma/discover/-/blob/master/discover/qml/DiscoverWindow.qml?ref_type=heads#L92 . That looks like it's supposed to say "Updates" when there is more than one update, but as far as I know, it always says "Update" even then. I think it should always say "Updates" even if there's only 1 update. I've just realised this could be an en_GB translation problem. Line https://invent.kde.org/plasma/discover/-/blob/master/po/en_GB/plasma-discover.po?ref_type=heads#L876 should probably be Updates not Update. (Although, as I keep saying, I think even "Updates (1)" would be fine - I feel like "Updates" is more like the name of a folder - for example in the same way that the Downloads folder is always called Downloads, and Pictures folder is always called Pictures, even if there's only one file in either of them). Created attachment 179073 [details]
Discover showing "Update" when multiple updates in en_GB
Yeah, definitely a translation bug. When Aleix and I talked about this we considered that maybe this should be a non-plural string though. i.e. Updates (0) Updates (1) Updates (42) since the page is itself called Updates regardless of how many entries there are If you could file a separate bug for the translation team that would be cool. Then we'll consider what to do on the discover side in this bug. (In reply to Harald Sitter from comment #5) > Yeah, definitely a translation bug. When Aleix and I talked about this we > considered that maybe this should be a non-plural string though. > i.e. > > Updates (0) > Updates (1) > Updates (42) > > since the page is itself called Updates regardless of how many entries there > are Yes, precisely my thinking too :) (In reply to Harald Sitter from comment #6) > If you could file a separate bug for the translation team that would be > cool. Then we'll consider what to do on the discover side in this bug. (In reply to Harald Sitter from comment #6) > If you could file a separate bug for the translation team that would be > cool. Then we'll consider what to do on the discover side in this bug. Thank you, have done. https://bugs.kde.org/show_bug.cgi?id=501020 So this bug can just be about the idea of having it always plural, in all translations. Sure, we can change it to always be plural. I think that's fine. Would you like to submit a patch to do that, John? (In reply to Nate Graham from comment #9) > Sure, we can change it to always be plural. I think that's fine. Would you > like to submit a patch to do that, John? I'm on it! A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/1049 |
Created attachment 178980 [details] Discover Update/Updates screenshot SUMMARY In the left-hand side category list, the entry "Update" should probably be "Updates". STEPS TO REPRODUCE 1. Run Discover 2. Look at the left-hand side category list 3. Note an entry initially called "Updates (Fetching...)" (click Refresh if necessary) 4. Wait for fetching/refreshing to finish OBSERVED RESULT The entry changes to "Update" followed by a number in brackets. EXPECTED RESULT The entry changes to "Updates" followed by a number in brackets. SOFTWARE/OS VERSIONS Operating System: openSUSE Tumbleweed 20250227 KDE Plasma Version: 6.3.2 KDE Frameworks Version: 6.11.0 Qt Version: 6.8.2 Kernel Version: 6.13.4-1-default (64-bit) Graphics Platform: X11 ADDITIONAL INFORMATION Note that when you click on the "Update" section, the search bar says "Search in 'Updates'...", and the heading to the right of that also says Updates.