Bug 500363

Summary:	Confirmed faces incorrectly confirms the next face in the list when using the keyboard
Product:	[Applications] digikam	Reporter:	Marshalleq <atoms>
Component:	Faces-Workflow	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	REPORTED ---
Severity:	normal	CC:	metzpinguin
Priority:	NOR
Version First Reported In:	8.6.0
Target Milestone:	---
Platform:	macOS (DMG)
OS:	macOS
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Marshalleq 2025-02-19 00:51:50 UTC

SUMMARY


STEPS TO REPRODUCE
1.  After faces are already scanned and recognised
2.  Go to an unconfirmed face under a confirmed persons name in the list under people
3.  Find a wrong face, start typing the correct name
4.  Scroll down to the matching (detected) name until it is highlighted for selection
5.  Press Enter

OBSERVED RESULT
The face to the right of the one you just selected also disappears as it is also confirmed without being selected

EXPECTED RESULT
Only the face that is highlighted should be confirmed

SOFTWARE/OS VERSIONS
macOS: 15.3


ADDITIONAL INFORMATION
I can correctly operate using the mouse, but it is faster with the keyboard, and speed while doing this is important.  The second face seems to be confirmed with the default name that is already on it rather than the name that is selected for the wrong face.  So depending on luck, this may or may not end up in the right place.

Comment 1 Maik Qualmann 2025-02-19 06:45:42 UTC

The issue has already been reported as Bug 499739. The problem is that we cannot reproduce it.
I will look into it again.

Maik

Comment 2 Maik Qualmann 2025-02-19 07:38:52 UTC

I think you're clearly holding down the enter key for too long. To reduce flicker effects, we first remove the items from view and then apply the face engine. This means that further input is available almost immediately. Let's see how we solve this...

Maik

Comment 3 Marshalleq 2025-02-19 07:45:38 UTC

(In reply to Maik Qualmann from comment #2)
> I think you're clearly holding down the enter key for too long. To reduce
> flicker effects, we first remove the items from view and then apply the face
> engine. This means that further input is available almost immediately. Let's
> see how we solve this...
> 
> Maik

While I can see the logic in your suggesting this, I can assure you I know how to press an enter key properly.  I have wondered if there is something sending a duplicate press but I would be seeing it on other things - I use computers extensively for my work and would have noticed.  As an aside, I am using a wireless Mac keyboard - if you think it's really important I could try a standard USB PC keyboard and press enter on instead to see if there's a difference, however I note the other person with this referenced below was running linux.  I could also try that and see if there's a difference if that helps in any way.

Thanks.

Comment 4 Marshalleq 2025-02-19 07:48:51 UTC

Also, just to note that so far this is 100% repeatable for me every time.  I can't actually stop it from happening.  And it's been happening for about a week since I started face tagging getting back from holiday.  At first I thought it was auto detecting a similar image on the right (as I have a few duplicates) but then I realised it was just any image on the right and it resulted in a lot of incorrect tags.  Please advise if there is any info I can provide given it's so reproducible.  I could probably do a screen record if necessary.

Comment 5 Maik Qualmann 2025-02-19 11:29:56 UTC

Git commit 515cee44b791e6a27301cc6445f16cdadabe1e72 by Maik Qualmann.
Committed on 19/02/2025 at 11:28.
Pushed by mqualmann into branch 'master'.

restore almost previous behavior when confirming faces
Related: bug 499739

M  +33   -33   core/app/items/views/digikamitemview.cpp

https://invent.kde.org/graphics/digikam/-/commit/515cee44b791e6a27301cc6445f16cdadabe1e72