| Summary: | Regression: systray takes non-symbolic icons despite the new feature should do the exact opposite | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Christian (Fuchs) <kde> |
| Component: | System Tray widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 4wy78uwh, akselmo, bondarenko, krazykath, materka, med.medin.2014, nate |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | 6.3.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/5bea2e5895adda2617b0fa0649b177cc20931108 | Version Fixed/Implemented In: | 6.3.2 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot of the issue, ktorrent and kmail should both be symbolic, but aren't | ||
|
Description
Christian (Fuchs)
2025-02-15 00:40:41 UTC
Can confirm the Kmail icon is colored, not symbolic. Operating System: Fedora Linux 41 KDE Plasma Version: 6.3.80 KDE Frameworks Version: 6.12.0 Qt Version: 6.8.2 Kernel Version: 6.12.13-200.fc41.x86_64 (64-bit) Graphics Platform: Wayland Processors: 12 × AMD Ryzen 5 3600 6-Core Processor Memory: 15.5 GiB of RAM Graphics Processor: AMD Radeon RX 6600 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5227 A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kiconthemes/-/merge_requests/175 *** Bug 500346 has been marked as a duplicate of this bug. *** Git commit 78ca2a2a1a52d20ccc98644156bc5b8067e45b68 by Nate Graham. Committed on 19/02/2025 at 19:41. Pushed by ngraham into branch 'master'. applets/systemtray: Don't unnecessarily append -symbolic to icon names 41d8bb43f6697b2cd5d3fd57790b9c35d69b11a8 removed a check that the icon name ends with "-symbolic" in favor of a function call to `iconLoader()->hasIcon(iconName + -symbolic)`. However this introduced a subtle bug: it will return true for icons that don't exist, if such icons have an acceptable fallback that does exist. This is not the behavior we want; we only want it to check the icon theme to see if a symbolic version of the icon name exists if we know it does not already end with -symbolic. FIXED-IN: 6.3.2 M +2 -1 applets/systemtray/statusnotifieritemsource.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/78ca2a2a1a52d20ccc98644156bc5b8067e45b68 Git commit 5bea2e5895adda2617b0fa0649b177cc20931108 by Nate Graham. Committed on 19/02/2025 at 20:07. Pushed by ngraham into branch 'Plasma/6.3'. applets/systemtray: Don't unnecessarily append -symbolic to icon names 41d8bb43f6697b2cd5d3fd57790b9c35d69b11a8 removed a check that the icon name ends with "-symbolic" in favor of a function call to `iconLoader()->hasIcon(iconName + -symbolic)`. However this introduced a subtle bug: it will return true for icons that don't exist, if such icons have an acceptable fallback that does exist. This is not the behavior we want; we only want it to check the icon theme to see if a symbolic version of the icon name exists if we know it does not already end with -symbolic. FIXED-IN: 6.3.2 (cherry picked from commit 78ca2a2a1a52d20ccc98644156bc5b8067e45b68) 046230ef applets/systemtray: Don't unnecessarily append -symbolic to icon names Co-authored-by: Nate Graham <nate@kde.org> M +2 -1 applets/systemtray/statusnotifieritemsource.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/5bea2e5895adda2617b0fa0649b177cc20931108 Happened after 6.3 update. Akregator tray icon became colourful. Operating System: CachyOS Linux KDE Plasma Version: 6.3.1 KDE Frameworks Version: 6.11.0 Qt Version: 6.8.2 Kernel Version: 6.13.4-2-cachyos (64-bit) Graphics Platform: Wayland Processors: 20 × Intel® Xeon® CPU E5-2640 v4 @ 2.40GHz Memory: 15.5 GiB of RAM Graphics Processor: AMD Radeon RX 5700 XT Manufacturer: INTEL Yes, and the fix is in 6.3.2. |