| Summary: | Context Menus have same "scale in" effect as normal windows | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Eamonn Rea <eamonnrea> |
| Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, oleg |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | 6.3.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/6e34985182f9e47772796cbc6e903f3f77dc5141 | Version Fixed In: | 6.3.1 |
| Sentry Crash Report: | |||
| Attachments: |
kwin support information
KWin QDbus Information |
||
|
Description
Eamonn Rea
2025-02-12 22:35:08 UTC
Please post the output of qdbus org.kde.KWin /KWin supportInformation Can confirm Operating System: Arch Linux KDE Plasma Version: 6.3.0 KDE Frameworks Version: 6.10.0 Qt Version: 6.8.2 Kernel Version: 6.13.2-2-cachyos (64-bit) Graphics Platform: Wayland Processors: 16 × AMD Ryzen 7 9800X3D 8-Core Processor Memory: 62.5 ГиБ of RAM Graphics Processor: AMD Radeon RX 6700 XT Manufacturer: ASUS Created attachment 178303 [details]
kwin support information
Here's mine
I enabled the same effects but popups are still animated as expected. Huh, now that I changed effects a couple of times they're now animated as supposed with "fade in/fade out". Previously popups would have "scale in" animation for me as well. (In reply to Oleg from comment #5) > Huh, now that I changed effects a couple of times they're now animated as > supposed with "fade in/fade out". Previously popups would have "scale in" > animation for me as well. Even after rebooting the computer? I will attach my KWin information after posting this comment, thanks for the direction!
> I enabled the same effects but popups are still animated as expected.
For the record, any animated behaviour is unexpected on my setup. Popups should not fade, or scale.
Since opening this issue I have also noticed that this affects some system tooltips (independent of the ones in some I believe QtQuick applications), but inconsistently. Tooltips on panels seem to do it consistently, but inside of applications (i.e. Firefox) it is inconsistent.
Created attachment 178326 [details]
KWin QDbus Information
(In reply to Eamonn Rea from comment #7) > I will attach my KWin information after posting this comment, thanks for the > direction! > > > I enabled the same effects but popups are still animated as expected. > > For the record, any animated behaviour is unexpected on my setup. Popups > should not fade, or scale. > > Since opening this issue I have also noticed that this affects some system > tooltips (independent of the ones in some I believe QtQuick applications), > but inconsistently. Tooltips on panels seem to do it consistently, but > inside of applications (i.e. Firefox) it is inconsistent. If you enable the fading popups effect, they are not scaled anymore, right? Ah, yes, correct. If I enable the Fade effect, this stops the scale issue described in this ticket. Disabling "Fade" resumes the scale behaviour described here :-) Okay, I think i know what's going on. It's connected to the fractional scaling changes. Wow, I am so sorry, I didn't even think to check my non-scaled displays. Now that you have mentioned it, I can add this issue does not happen on unscaled displays. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/7150 Git commit 78cb68b655d42cb8728ada17178e0f521c2f3f86 by Vlad Zahorodnii. Committed on 14/02/2025 at 01:44. Pushed by vladz into branch 'master'. effect: Fix EffectWindow::hasDecoration() The fractional part in the width() and the height() is truncated by the QRect(). This makes the hasDecoration() function return true for popups with fractional scaling. The scale effect checks whether a window has a decoration to determine whether it can be animated. The issue can be resolved by changing the QRect to a QRectF but a more robust way to fix the bug is to inspect the Window::decoration property. M +1 -1 src/effect/effectwindow.cpp https://invent.kde.org/plasma/kwin/-/commit/78cb68b655d42cb8728ada17178e0f521c2f3f86 Git commit 6e34985182f9e47772796cbc6e903f3f77dc5141 by Vlad Zahorodnii. Committed on 14/02/2025 at 02:17. Pushed by vladz into branch 'Plasma/6.3'. effect: Fix EffectWindow::hasDecoration() The fractional part in the width() and the height() is truncated by the QRect(). This makes the hasDecoration() function return true for popups with fractional scaling. The scale effect checks whether a window has a decoration to determine whether it can be animated. The issue can be resolved by changing the QRect to a QRectF but a more robust way to fix the bug is to inspect the Window::decoration property. (cherry picked from commit 78cb68b655d42cb8728ada17178e0f521c2f3f86) Co-authored-by: Vlad Zahorodnii <vlad.zahorodnii@kde.org> M +1 -1 src/effect/effectwindow.cpp https://invent.kde.org/plasma/kwin/-/commit/6e34985182f9e47772796cbc6e903f3f77dc5141 In addition to fixing the bug as described in this report, this appears to have also fixed the long-standing issue of this happening on XWayland applications as well (most notably, Steam)!!!! Awesome stuff, thank you so much :-) |