| Summary: | Location 'Koeln/bonn' has typo | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Thomas Braun <grothesk> |
| Component: | Weather widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | minor | CC: | isma.af, kamkaz, kde, nate |
| Priority: | NOR | ||
| Version First Reported In: | 6.3.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Thomas Braun
2025-02-11 21:29:50 UTC
I don't think it's necessarily a KDE issue. The name comes from the list of weather station provided by Deutscher Wetterdienst (DWD) / German Weather Service. This station list does not contain umlauts. You can find the station list here: https://www.dwd.de/DE/leistungen/met_verfahren_mosmix/mosmix_stationskatalog.cfg The processing of this list happens in kde/src/plasma-workspace/dataengines/weather/ions/dwd/ion_dwd.cpp:240-310 I am unsure, what is the best approach here. Definitely, the issue is with the original form of the list. Can we make it any better? Can we safely replace all the ss/oe/ue/ae from this list with an umlaut? I am not sure. Do these letters occur "naturally" in the language? I think there are more issues with this weather provider. This list in particular has many other city names without proper national letters. A better, but not easy to parse list can be found here: https://www.dwd.de/EN/ourservices/globalclimatedata/stationsverzeichnis.html But again, all the names are German, not international. It seems like there are some missing stations on this list too, that are working just fine. It begs a question, why in kde/src/kdeplasma-addons/applets/weather/plugin/locationlistmodel.cpp:83 are the results from DWD rated so high, above bbcukmet? Since the user experience with these station names from DWD is most likely subpar. Another related issue, sorting of the elements on the list of available weather stations seems to be inconsistent too, and not necessarily related to the priorities given to the providers in code. It might lead to subpar experience, and in some cases a worse default being chosen. > Can we safely replace all the ss/oe/ue/ae from this list with an umlaut? Short answer: No, I tried. It works for the most times for German cities, but the provider also serves other European cities that doesn't follow this gramatical rule where the conversion to an umlaut vowel totally fails. Detecting if the city is German *may* work but I remember there's no reliable way (without resorting to another provider or external data) It is also not a typo, but a grammatically valid, while uncommon, way of writting. Or at least it used to be this way IIRC. > I don't think it's necessarily a KDE issue Ii is not. We can try to make it up, but it's the providers station list which limits us. I'm not setting the report as upstream because of the "/" part. Capitalizing after a slash feels a doable request. > are the results from DWD rated so high, above bbcukmet? > Another related issue, sorting of the elements Because until recent versions, where I refactored the BBC provider, the information of that provider was way worse. It's not DWD which is heigh, but BBC it is rated lower than it should. DWD also offers weather warnings (for German locations) The sorting is probably not stable and should also use alphabetic order, but please use a different bug report for a different issue. Another point why automatic oe -> ö cannot work: There are German cities where the proper spelling is that way for example Soest How about making the Location editable by the user? Is having a local list of stations an acceptable option? It would be ~1500 entries that would have to be mostly hand edited, but it would give us actual control over the displayed text in a user-friendly manner A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5193 Git commit 75a0f4cd227ef49a42f86494d2a03fb5330ec99b by Ismael Asensio. Committed on 13/02/2025 at 10:18. Pushed by iasensio into branch 'master'. weather/dwd: Capitalize letters after slash M +1 -1 dataengines/weather/ions/dwd/ion_dwd.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/75a0f4cd227ef49a42f86494d2a03fb5330ec99b A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5196 Git commit 946ae6851c87d99ffeb46830d905711f0ea4ce93 by Ismael Asensio. Committed on 13/02/2025 at 10:56. Pushed by iasensio into branch 'Plasma/6.3'. weather/dwd: Capitalize letters after slash (cherry picked from commit 75a0f4cd227ef49a42f86494d2a03fb5330ec99b) Co-authored-by: Ismael Asensio <isma.af@gmail.com> M +1 -1 dataengines/weather/ions/dwd/ion_dwd.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/946ae6851c87d99ffeb46830d905711f0ea4ce93 Ismael, is there anything else feasible we can do here? Or are we now at the mercy of the data provider? (In reply to Nate Graham from comment #12) > Ismael, is there anything else feasible we can do here? Or are we now at the > mercy of the data provider? Not really, apart from shipping a local curated version of the stations list, which is being tracked in https://invent.kde.org/plasma/plasma-workspace/-/issues/142 (with extra quality motivations apart from spelling). I'm wondering if it's worth repurposing this BR for that end. The other unrelated issues mentioned have been already handled for Plasma 6.3.1 or 6.4 Thanks, I thought so. Then I'm afraid we've done all we feasibly can here given the issues with the data source itself. |