| Summary: | Maximized window title stuck after fullscreen-ing video | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Jakob Petsovits <jpetso> |
| Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | CC: | cwo.kde, kde, nate, nope1000000 |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=500976 | ||
| Latest Commit: | https://invent.kde.org/plasma/breeze/-/commit/27685e2e12b7356db1947f7d2b7e46fb8becc720 | Version Fixed In: | 6.3.0 |
| Sentry Crash Report: | |||
| Attachments: | KWin Support Information | ||
|
Description
Jakob Petsovits
2025-01-28 01:15:20 UTC
Oh yeah, in order to experience this bug, you may need to manually enable the system title bar. In Firefox: 1. Right-click anywhere on the toolbar, then click "Customize toolbar..." 2. Check "Title Bar" on the bottom right. In Chromium: 1. Right-click in the free space on the tab bar / CSD title bar, then click "Use system title bar and borders". I followed the provided steps but I cannot reproduce the bug Hm, I can't reproduce it either, but I have noticed my Firefox windows getting their title stuck occasionally as well (on stock Firefox, Plasma master). Let me rebuild latest KWin master and retest. Created attachment 177782 [details]
KWin Support Information
Still reproducible on today's KWin master, git commit 6e95287fb5f1934b7de3d29f224dd2166fb9d63b. Maybe the problem is with another component - I also updated kwayland as a build requirement, but only a handful of other repos are fully up to date.
I'll try separately updating my (Arch) base packages and the rest of Plasma/KF6. Hopefully it's been fixed at some layer in the stack, or finding the difference between my system and yours is going to be more painful.
I guess there's also a possibility that this exposes some kind of race condition. I run debug builds for everything in my KDE build, which combined with a 5-year-old Intel system makes it naturally slower than some other setups. Qt, Firefox, Chromium and other base libraries are standard release-build Arch packages. I can try debugging it myself, but it would take me a good while to understand the relevant code and set up a debugging environment that lets me do gdb things with KWin. Hold on - the title just got stuck for me also on my initial Firefox window now where I was not doing anything fullscreen-related. So the video helped to reproduce the bug (and very reliably so, on my system) but fullscreen isn't a necessity. I don't think I even had a video element present on the few pages that were open in this Firefox window since restarting the session, just KDE Bugs, Invent, GitHub and my lean email provider. So it seems like a broader issue. But still unsure how to reliably reproduce it in a different way. Oh, fun. The browser window must be maximized for this to reproduce. If I try the reproduction steps with a non-maximized window, the bug does not surface. I've been able to reproduce this on Arch Linux under KDE Plasma 6.2.91 (Beta 2). Problem Description: Firefox is unable to update the window title bar field after it goes from maximized mode to borderless full screen mode (either via "play video full screen" option or the "F11" key). Set up: * I am using AMDGPU, hardware video acceleration, and Wayland. * Firefox is set to use the system provided title bar under the "Customize Toolbar" menu. * Firefox is maximized. * A mixture of tabs (both video and non-video) are active in Firefox. Reproduction Steps and Findings: 1. Navigate among various Firefox tabs while Firefox is maximized. The window title updates normally. 2. Trigger the current tab to go borderless full screen by pressing the "F11" key. Window title updates normally. 3. Press "F11" to return to maximized mode. Window title is now stuck on the last borderless full screen title bar. 4. Navigate among various Firefox tabs while Firefox is maximized. The window title no longer updates and is still stuck at the last borderless full screen value. 5. Pressing "F11" twice to temporarily trigger a return to borderless full screen will update the title bar to the currently active tab. It does not resolve the stuck title bar issue. A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/514 A possibly relevant merge request was started @ https://invent.kde.org/plasma/oxygen/-/merge_requests/65 Git commit 31998126b20324eb97c920cc00a3aa1a4f17a7c4 by Vlad Zahorodnii. Committed on 31/01/2025 at 15:59. Pushed by vladz into branch 'master'. kdecoration: Update titlebar when borders change updateTitleBar() uses borderTop() so it should be called again when borders change. The root cause of the bug: when the caption changes, breeze is going to schedule a repaint for titleBar(). Since it's not properly updated when the borders change, the title bar may not be repainted as expected. M +1 -0 kdecoration/breezedecoration.cpp https://invent.kde.org/plasma/breeze/-/commit/31998126b20324eb97c920cc00a3aa1a4f17a7c4 Git commit 27685e2e12b7356db1947f7d2b7e46fb8becc720 by Vlad Zahorodnii. Committed on 31/01/2025 at 15:59. Pushed by vladz into branch 'Plasma/6.3'. kdecoration: Update titlebar when borders change updateTitleBar() uses borderTop() so it should be called again when borders change. The root cause of the bug: when the caption changes, breeze is going to schedule a repaint for titleBar(). Since it's not properly updated when the borders change, the title bar may not be repainted as expected. (cherry picked from commit 31998126b20324eb97c920cc00a3aa1a4f17a7c4) 9fc41c08 kdecoration: Update titlebar when borders change Co-authored-by: Vlad Zahorodnii <vlad.zahorodnii@kde.org> M +1 -0 kdecoration/breezedecoration.cpp https://invent.kde.org/plasma/breeze/-/commit/27685e2e12b7356db1947f7d2b7e46fb8becc720 Git commit 584a65ee985ec510278cd31e97abd9051e8585cb by Vlad Zahorodnii. Committed on 31/01/2025 at 12:21. Pushed by vladz into branch 'master'. kdecoration: Update titlebar when borders change updateTitleBar() uses borderTop() so it should be called again when borders change. M +1 -0 kdecoration/oxygendecoration.cpp https://invent.kde.org/plasma/oxygen/-/commit/584a65ee985ec510278cd31e97abd9051e8585cb A possibly relevant merge request was started @ https://invent.kde.org/plasma/oxygen/-/merge_requests/66 Git commit 96b9ce29d1c02639a6243241072b5ac746f852d1 by Vlad Zahorodnii. Committed on 01/02/2025 at 16:40. Pushed by vladz into branch 'Plasma/6.3'. kdecoration: Update titlebar when borders change updateTitleBar() uses borderTop() so it should be called again when borders change. (cherry picked from commit 584a65ee985ec510278cd31e97abd9051e8585cb) Co-authored-by: Vlad Zahorodnii <vlad.zahorodnii@kde.org> M +1 -0 kdecoration/oxygendecoration.cpp https://invent.kde.org/plasma/oxygen/-/commit/96b9ce29d1c02639a6243241072b5ac746f852d1 It seems that the commit applied to oxygen for solving this bug is now causing another bug https://bugs.kde.org/show_bug.cgi?id=500976 This is present since KDE Plasma 6.3.0 No need to re-open this if there's a new and separate issue; closing again. No need to re-open this if there's a *new* issue; re-closing and marking the new issue as related. |