| Summary: | Incorrect output in column "Amount" and "Balance for report "Investment Transactions" | ||
|---|---|---|---|
| Product: | [Applications] kmymoney | Reporter: | Ralf Habacker <ralf.habacker> |
| Component: | reports | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | 5.1.90 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/office/kmymoney/-/commit/8a9fe45acdb28d901dc4fa5e6814e6b2b1383d43 | Version Fixed In: | 5.2 |
| Sentry Crash Report: | |||
| Attachments: |
test file
Screenshot showing the issue |
||
|
Description
Ralf Habacker
2025-01-27 04:18:19 UTC
Created attachment 177707 [details]
Screenshot showing the issue
Comment on attachment 177707 [details]
Screenshot showing the issue
On closer examination of this topic, I wonder whether the market values belong in the transaction report at all?
In the normal transaction report, the opening and closing balance is shown at this point, which corresponds to the actual balance of the account at that time. However, the market values are not real values in the account.
And the other thing is: Are the totals an “amount” or a “balance”? I would say a balance, so they belong in the balance column
(In reply to Ralf Habacker from comment #2) > Comment on attachment 177707 [details] > Screenshot showing the issue > When comparing with a report created from a kmymoney binary build of the previous major version https://bugs.kde.org/attachment.cgi?id=177725, it turns out that the confusion in 5.x is caused by the change of sign in the “Balance” column. 4.8.5 Initial market value 0 Transfer to investment 1000 End market value 1400 This account balance is comprehensible 5.x Initial market value 0 Transfer to investment -1000 End market value 1400 This not Comment on attachment 177707 [details]
Screenshot showing the issue
As it turned out, the content of the balance column is not displayed correctly, which is why this screenshot is inappropriate and has been removed.
A possibly relevant merge request was started @ https://invent.kde.org/office/kmymoney/-/merge_requests/261 Git commit fdbf8d63f570324a7ec13baa968188eb31e54135 by Ralf Habacker. Committed on 20/02/2025 at 12:32. Pushed by habacker into branch 'master'. In querytable-test write also kmymoney test files By loading these file into kmymoney a visual inspection is now also possible. M +29 -0 kmymoney/plugins/views/reports/core/tests/querytable-test.cpp https://invent.kde.org/office/kmymoney/-/commit/fdbf8d63f570324a7ec13baa968188eb31e54135 Git commit 0a334f7e2fd41a8f84eee3d17dc8c82770ec23ff by Ralf Habacker. Committed on 20/02/2025 at 12:32. Pushed by habacker into branch 'master'. Adjust expected return values for investment transaction report test case M +17 -17 kmymoney/plugins/views/reports/core/tests/data/test-investment-report-querytable-Investment-Transactions-_Customized_.csv https://invent.kde.org/office/kmymoney/-/commit/0a334f7e2fd41a8f84eee3d17dc8c82770ec23ff Git commit 8a9fe45acdb28d901dc4fa5e6814e6b2b1383d43 by Ralf Habacker. Committed on 20/02/2025 at 12:32. Pushed by habacker into branch 'master'. Revert incorrect handling of investment transactions The reason 'switch over from stock split to asset split because amount in stock split doesn't take fees/interests into account' is incorrect as fees/interest are transfered from the brokerage account to the assigned fee/interest account and are not visible in the investment account. FIXED-IN:5.2 M +0 -41 kmymoney/plugins/views/reports/core/querytable.cpp https://invent.kde.org/office/kmymoney/-/commit/8a9fe45acdb28d901dc4fa5e6814e6b2b1383d43 Git commit 291dd8594d03e19ad7f5b6bf9b9a42a0b3d94f96 by Ralf Habacker. Committed on 20/02/2025 at 12:32. Pushed by habacker into branch 'master'. Also in querytable-test fix expected values in investment transaction report M +28 -33 kmymoney/plugins/views/reports/core/tests/querytable-test.cpp https://invent.kde.org/office/kmymoney/-/commit/291dd8594d03e19ad7f5b6bf9b9a42a0b3d94f96 |