Bug 498949

Summary:	Hardcoded path of ffmpeg for whisper and vosk is no longer the right one
Product:	[Applications] kdenlive	Reporter:	afk
Component:	Title Clips & Subtitles	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal	CC:	fritzibaby
Priority:	NOR	Keywords:	triaged
Version First Reported In:	24.12.1
Target Milestone:	---
Platform:	Homebrew (macOS)
OS:	macOS
Latest Commit:	https://invent.kde.org/multimedia/kdenlive/-/commit/37b97ddfc6e8caa33bb3c8ae0e946515c4e2666f	Version Fixed In:	24.12.2
Sentry Crash Report:
Attachments:	Error window

Description afk 2025-01-21 09:00:11 UTC

Created attachment 177565 [details]
Error window

SUMMARY
Path of python script has changed since 24.08.1 so the hardcoded path no longer works :

For vosk : https://github.com/KDE/kdenlive/blob/aadbc071e11e1efad05a553c5896821149083ed5/data/scripts/vosk/speech.py#L28
    path = abspath(join(dirname(__file__), '../../MacOS/ffmpeg'))

For whisper : (code is duplicated at line 48 and 104, may be using the function at 48 would be useful)
https://github.com/KDE/kdenlive/blob/aadbc071e11e1efad05a553c5896821149083ed5/data/scripts/whisper/whispertotext.py#L48
https://github.com/KDE/kdenlive/blob/aadbc071e11e1efad05a553c5896821149083ed5/data/scripts/whisper/whispertotext.py#L104

would be nice to pass the ffmpeg from the settings or else add another ../
it should be in 
/Applications/kdenlive.app/Contents/MacOS/ffmpeg
and its looking for
/Applications/kdenlive.app/Contents/Resources/MacOS/ffmpeg

STEPS TO REPRODUCE
1. Install kdenlive from brew or the website
2. use the speech editor
3. got a message that says it doesn't find ffmpeg

OBSERVED RESULT
ffmpeg isn't at /Applications/kdenlive.app/Contents/Resources/MacOS/ffmpeg so it doesn't work

EXPECTED RESULT
/Applications/kdenlive.app/Contents/MacOS/ffmpeg should be used instead

SOFTWARE/OS VERSIONS
macOS: 15.2

ADDITIONAL INFORMATION

Comment 1 Jean-Baptiste Mardelle 2025-01-22 08:46:44 UTC

Thanks for your detailled report. I will work on a fix for 24.12.2

Comment 2 Jean-Baptiste Mardelle 2025-01-23 12:21:32 UTC

Git commit 59e0293ec1f4e872895036a521c96830d4a44013 by Jean-Baptiste Mardelle.
Committed on 23/01/2025 at 12:21.
Pushed by mardelle into branch 'master'.

Cleanup speech scripts, fix hardcoded ffmpeg path breaking whisper and vosk on Mac, add system packages checkbox

M  +12   -17   data/scripts/automask/sam-objectmask.py
M  +2    -6    data/scripts/checkgpu.py
M  +79   -59   data/scripts/vosk/speech.py
M  +63   -42   data/scripts/vosk/speechtotext.py
M  +5    -7    data/scripts/whisper/seamlessquery.py
M  +16   -18   data/scripts/whisper/whisperquery.py
M  +23   -18   data/scripts/whisper/whispertosrt.py
M  +63   -47   data/scripts/whisper/whispertotext.py
M  +1    -1    src/assets/keyframes/model/automask/automaskhelper.cpp
M  +1    -1    src/assets/keyframes/model/automask/automaskhelper.hpp
M  +53   -14   src/dialogs/settings/pluginssettings.cpp
M  +15   -4    src/dialogs/speechdialog.cpp
M  +44   -29   src/dialogs/textbasededit.cpp
M  +2    -2    src/effects/effectstack/view/maskmanager.cpp
M  +1    -1    src/effects/effectstack/view/maskmanager.hpp
M  +8    -0    src/kdenlivesettings.kcfg
M  +2    -2    src/monitor/monitor.cpp
M  +2    -2    src/monitor/monitor.h
M  +13   -3    src/pythoninterfaces/abstractpythoninterface.cpp
M  +2    -1    src/pythoninterfaces/abstractpythoninterface.h
M  +5    -0    src/pythoninterfaces/saminterface.cpp
M  +1    -0    src/pythoninterfaces/saminterface.h
M  +27   -0    src/pythoninterfaces/speechtotext.cpp
M  +2    -0    src/pythoninterfaces/speechtotext.h
M  +267  -178  src/ui/configspeech_ui.ui

https://invent.kde.org/multimedia/kdenlive/-/commit/59e0293ec1f4e872895036a521c96830d4a44013

Comment 3 Jean-Baptiste Mardelle 2025-01-23 12:53:52 UTC

Git commit 37b97ddfc6e8caa33bb3c8ae0e946515c4e2666f by Jean-Baptiste Mardelle.
Committed on 23/01/2025 at 12:53.
Pushed by mardelle into branch 'release/24.12'.

Fix FFmpeg for STT not found on Mac
FIXED-IN: 24.12.2

M  +1    -1    data/scripts/vosk/speech.py
M  +1    -1    data/scripts/vosk/speechtotext.py
M  +2    -2    data/scripts/whisper/whispertotext.py

https://invent.kde.org/multimedia/kdenlive/-/commit/37b97ddfc6e8caa33bb3c8ae0e946515c4e2666f