Bug 498462

Summary: Digital Clock calendar shows holidays in January twice
Product: [Frameworks and Libraries] frameworks-kholidays Reporter: kskos2
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: CONFIRMED ---    
Severity: normal CC: nate, qydwhotmail
Priority: NOR    
Version First Reported In: 6.10.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: holidays appear twice
holidays appear once

Description kskos2 2025-01-10 11:14:39 UTC
Created attachment 177252 [details]
holidays appear twice

SUMMARY
The calendar plugin of Digital Clock Widget shows a holiday twice.

STEPS TO REPRODUCE
1. make holidays plugin enable in Digital Clock Settings.
2. Choose South Korea in holidays
3. Choose January and take a look on 28, 29, 30
OBSERVED RESULT
 you can find that 28-30 of January (설날 aka  lunar new year) appears twice.
If you choose February , you can find lunar new year appears once. 

EXPECTED RESULT
calendar should show a holiday once.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
(available in the Info Center app, or by running `kinfo` in a terminal window)
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 6.2.5
KDE Frameworks Version: 6.9.0
Qt Version: 6.8.1

ADDITIONAL INFORMATION
Comment 1 kskos2 2025-01-10 11:47:05 UTC
Created attachment 177254 [details]
holidays appear once
Comment 2 Nate Graham 2025-01-13 17:53:48 UTC
Cannot reproduce it myself with United States holidays. Do you by any chance have an "Alternate Calendar" set up as well?
Comment 3 kskos2 2025-01-14 00:49:21 UTC
(In reply to Nate Graham from comment #2)
> Cannot reproduce it myself with United States holidays. Do you by any chance
> have an "Alternate Calendar" set up as well?

No. I don't have alternate calendar.
I have looked into when this happens.
1. This happens only on lunar new year(aka 설날). On any other Korean holiday, this does not happen.
2. This happens only when January Calendar contains  lunar new year in its view.

Korean Holidays defined in the link https://invent.kde.org/frameworks/kholidays/-/blob/13b89c4b193f6497f8cb67620f1adceb496a8d7d/holidays/plan2/holiday_kr_ko

Please understand my poor English. thanks
Comment 4 Fushan Wen 2025-01-14 16:09:54 UTC
Can reproduce
Comment 5 Fushan Wen 2025-01-22 15:04:41 UTC
KHolidays loads holidays in January twice, but I don't quite understand how it parses the data file.