Summary: | Switching from Desktop containment to Folder containment crashes Plasma in Positioner::updatePositionsList | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Nate Graham <nate> |
Component: | Containment | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | akselmo, notmart |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/c387739d24a7b75fbf38563fe5cffc232decebc5 | Version Fixed In: | 6.3.0 |
Sentry Crash Report: |
Description
Nate Graham
2025-01-09 04:38:37 UTC
can reproduce A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2703 Git commit 239ffd7014b0ba93fe4be3079e1d6352dcea25a5 by Marco Martin. Committed on 09/01/2025 at 14:34. Pushed by mart into branch 'master'. containments/desktop: Execute updatePositionsList only if we know how many icons per stripe updatePositionsList() is not always guaranteed to be called after setPerStripe has been called. setPerStripe is called by rowsInserted and setPerStripe by the QML ui so if the model is ready before the ui we'll have a divide by zero M +1 -1 containments/desktop/plugins/folder/positioner.cpp https://invent.kde.org/plasma/plasma-desktop/-/commit/239ffd7014b0ba93fe4be3079e1d6352dcea25a5 Git commit c387739d24a7b75fbf38563fe5cffc232decebc5 by Marco Martin. Committed on 09/01/2025 at 16:47. Pushed by mart into branch 'Plasma/6.3'. containments/desktop: Execute updatePositionsList only if we know how many icons per stripe updatePositionsList() is not always guaranteed to be called after setPerStripe has been called. setPerStripe is called by rowsInserted and setPerStripe by the QML ui so if the model is ready before the ui we'll have a divide by zero (cherry picked from commit 239ffd7014b0ba93fe4be3079e1d6352dcea25a5) 239ffd70 containments/desktop: Execute updatePositionsList only if we know how many icons per stripe Co-authored-by: Marco Martin <notmart@gmail.com> M +1 -1 containments/desktop/plugins/folder/positioner.cpp https://invent.kde.org/plasma/plasma-desktop/-/commit/c387739d24a7b75fbf38563fe5cffc232decebc5 |