Bug 498075

Summary: Build fails after upgrading from qxlsx-1.4.9 to qxlsx-1.5.0
Product: [Applications] LabPlot2 Reporter: Chris <chrisretusn>
Component: backendAssignee: Stefan Gerlach <stefan.gerlach>
Status: RESOLVED FIXED    
Severity: normal CC: chrisretusn, stefan.gerlach
Priority: NOR    
Version First Reported In: 2.11.1   
Target Milestone: ---   
Platform: Slackware   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Chris 2024-12-31 06:54:33 UTC
SUMMARY
Build fails after upgrading from qxlsx-1.4.9 to qxlsx-1.5.0 (also 1.4.10)

STEPS TO REPRODUCE
1. Upgrade qxlsx from 1.4.9 to 1.4.10 or 1.5.0
2. Rebuild labplot, no changes to configuration.

OBSERVED RESULT
Build fails

EXPECTED RESULT
Build succeeds. 

SOFTWARE/OS VERSIONS
Operating System: Slackware 15.0+ 
KDE Plasma Version: 5.27.11
KDE Frameworks Version: 5.116.0
Qt Version: 5.15.16

ADDITIONAL INFORMATION
Labplot build succeeds with qxlsx-1.4.8
Last few lines of build output:
[ 99%] Built target labplot2lib
/home/non-slack/slackbuilds/labplot/tmp/labplot-2.11.1/src/backend/datasources/filters/XLSXFilter.cpp: In member function ‘bool XLSXFilterPrivate::dataRangeCanBeExportedToMatrix(const QXlsx::CellRange&) const’:
/home/non-slack/slackbuilds/labplot/tmp/labplot-2.11.1/src/backend/datasources/filters/XLSXFilter.cpp:760:62: error: unable to deduce ‘const auto*’ from ‘QXlsx::Document::cellAt(int, int) const(i, j)’
  760 |                         const auto* cell = m_document->cellAt(i, j);
      |                                            ~~~~~~~~~~~~~~~~~~^~~~~~
/home/non-slack/slackbuilds/labplot/tmp/labplot-2.11.1/src/backend/datasources/filters/XLSXFilter.cpp:760:67: note:   mismatched types ‘const auto*’ and ‘std::shared_ptr<QXlsx::Cell>’
  760 |                         const auto* cell = m_document->cellAt(i, j);
      |                                                                   ^
/home/non-slack/slackbuilds/labplot/tmp/labplot-2.11.1/src/backend/datasources/filters/XLSXFilter.cpp: In member function ‘QXlsx::Cell::CellType XLSXFilterPrivate::columnTypeInRange(int, const QXlsx::CellRange&) const’:
/home/non-slack/slackbuilds/labplot/tmp/labplot-2.11.1/src/backend/datasources/filters/XLSXFilter.cpp:795:62: error: unable to deduce ‘const auto*’ from ‘QXlsx::Document::cellAt(int, int) const(row, ((int)column))’
  795 |                         const auto* cell = m_document->cellAt(row, column);
      |                                            ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
/home/non-slack/slackbuilds/labplot/tmp/labplot-2.11.1/src/backend/datasources/filters/XLSXFilter.cpp:795:74: note:   mismatched types ‘const auto*’ and ‘std::shared_ptr<QXlsx::Cell>’
  795 |                         const auto* cell = m_document->cellAt(row, column);
      |                                                                          ^
gmake[2]: *** [src/CMakeFiles/labplot2backendlib.dir/build.make:1022: src/CMakeFiles/labplot2backendlib.dir/backend/datasources/filters/XLSXFilter.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:1249: src/CMakeFiles/labplot2backendlib.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
Comment 1 Bug Janitor Service 2025-01-06 15:20:27 UTC
A possibly relevant merge request was started @ https://invent.kde.org/education/labplot/-/merge_requests/641
Comment 2 Stefan Gerlach 2025-01-06 22:03:28 UTC
Fixed with commit aa054bf3d611916c44c74473883bd2827df02c41.

FIXED-IN: 2.12.0