| Summary: | KRDC fails to build due to newer version of FreeRDP version 3.10.3 available | ||
|---|---|---|---|
| Product: | [Applications] krdc | Reporter: | Vlad Korol <chocolatemagnate> |
| Component: | general | Assignee: | Urs Wolfer <uwolfer> |
| Status: | RESOLVED NOT A BUG | ||
| Severity: | minor | CC: | luigi.toscano, omerusta |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | attachment-1847327-0.html | ||
|
Description
Vlad Korol
2024-12-29 14:36:45 UTC
If you check the code, it already supports FreeRDP 3. https://invent.kde.org/network/krdc/-/blob/40418a0e6f2973a2b561cf2d963627fa1ac8cf3b/CMakeLists.txt#L144 You need to set some configuration settings as described here: https://invent.kde.org/network/krdc/-/merge_requests/113 (In reply to Luigi Toscano from comment #1) > If you check the code, it already supports FreeRDP 3. > https://invent.kde.org/network/krdc/-/blob/ > 40418a0e6f2973a2b561cf2d963627fa1ac8cf3b/CMakeLists.txt#L144 > You need to set some configuration settings as described here: > https://invent.kde.org/network/krdc/-/merge_requests/113 Thank you a lot for fast response! I am sorry for not seeing it earlier. How do you make it work with kde-builder? I am building with it, and from the looks of it, kde-builder is a wrapper around Cmake. I am new to KDE Plasma development, so could you perhaps orient me how to enable this specific feature? I got this error when building with the command: kde-builder workspace btw have you tried installing freerdp2-devel package on your fedora ? [ you can have both 3 and 2 in same time ] Created attachment 176950 [details] attachment-1847327-0.html On 12/29/24 17:33, Ömer Fadıl USTA wrote: > https://bugs.kde.org/show_bug.cgi?id=498018 > > Ömer Fadıl USTA<omerusta@gmail.com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > CC| |omerusta@gmail.com > > --- Comment #3 from Ömer Fadıl USTA<omerusta@gmail.com> --- > btw have you tried installing freerdp2-devel package on your fedora ? [ you can > have both 3 and 2 in same time ] > Good question! Actually no, I thought this was a continuous package just freerdp-devel and dnf installed the third version. Didn't actually know you can use the second one too, I will try to build with the second version and report back. > (In reply to Luigi Toscano from comment #1) > > If you check the code, it already supports FreeRDP 3. > > https://invent.kde.org/network/krdc/-/blob/ > > 40418a0e6f2973a2b561cf2d963627fa1ac8cf3b/CMakeLists.txt#L144 > > You need to set some configuration settings as described here: > > https://invent.kde.org/network/krdc/-/merge_requests/113 > (In reply to Vlad Korol from comment #2) > Thank you a lot for fast response! I am sorry for not seeing it earlier. How > do you make it work with kde-builder? I am building with it, and from the > looks of it, kde-builder is a wrapper around Cmake. I am new to KDE Plasma > development, so could you perhaps orient me how to enable this specific > feature? I got this error when building with the command: I'm sorry, I don't use kde-builder yet. Have you checked its documentation at https://kde-builder.kde.org/ ? I think you should be able to set per-repository options. Side note: please note that krdc is not part of Plasma. It is developed by the KDE community and shipped as part of the KDE Gear bundle. (In reply to Luigi Toscano from comment #5) > > (In reply to Luigi Toscano from comment #1) > > > If you check the code, it already supports FreeRDP 3. > > > https://invent.kde.org/network/krdc/-/blob/ > > > 40418a0e6f2973a2b561cf2d963627fa1ac8cf3b/CMakeLists.txt#L144 > > > You need to set some configuration settings as described here: > > > https://invent.kde.org/network/krdc/-/merge_requests/113 > > > (In reply to Vlad Korol from comment #2) > > Thank you a lot for fast response! I am sorry for not seeing it earlier. How > > do you make it work with kde-builder? I am building with it, and from the > > looks of it, kde-builder is a wrapper around Cmake. I am new to KDE Plasma > > development, so could you perhaps orient me how to enable this specific > > feature? I got this error when building with the command: > > I'm sorry, I don't use kde-builder yet. Have you checked its documentation > at https://kde-builder.kde.org/ ? > I think you should be able to set per-repository options. > > Side note: please note that krdc is not part of Plasma. It is developed by > the KDE community and shipped as part of the KDE Gear bundle. Thanks for suggesting! The website is just called `kde.org`, so I thought KDE issues could be reported here too. I found out there is a fix that allows to set Cmake options in kde-builder. For anyone finding this issue, you can enable FreeRDP version 3 either globally: > global > cmake-options -DWITH_RDP=OFF -DWITH_RDP3=ON > end global or for krdc individually: > module krdc > cmake-options -DWITH_RDP=OFF -DWITH_RDP3=ON > end module into your ~/.config/kdesrc-buildrc file. (In reply to Vlad Korol from comment #6) > (In reply to Luigi Toscano from comment #5) > > Side note: please note that krdc is not part of Plasma. It is developed by > > the KDE community and shipped as part of the KDE Gear bundle. > > Thanks for suggesting! The website is just called `kde.org`, so I thought > KDE issues could be reported here too. Yes, krdc issues should be reported here too, just like other issues of (almost) any other stuff developed by the KDE community. Just pointing out that "KDE" and "Plasma" are not the same thing, Plasma is just a part of the stuff produced by KDE, and krdc is not part of Plasma. |