Bug 497738

Could you provide a screenshot? It's a bit hard to understand what's happening based on the description only.

Hi,

screenshot_20241221_120135.png shows the correct time markers, also the KiKA time marker is now correct. In the morning there was an entry "program break" ("Sendepause") from yesterday 21:00 to today 6:00 completely marked in blue already at 05:15.

If I now scroll down, see screenshot_20241221_120146.png, a program for the KiKA channel is also marked in blue for tomorrow from 06:00, just as it was this morning. As you can see, the screenshots were taken at 12:01.

This morning, when I opened Telly Scout for the first time for today, before I clicked on “Refetch”, the blue markers for all channels were in the correct positions, but all programs above these correct positions, i.e. the programs that were already over, were also marked in blue.

Regards,
Ralf

Created attachment 176800 [details]
screenshot_20241221_120135.png

Created attachment 176801 [details]
screenshot_20241221_120146.png

To put it another way: When I opened Telly Scout for the first time today, all shaded programs were also highlighted in blue.

A possibly relevant merge request was started @ https://invent.kde.org/utilities/telly-skout/-/merge_requests/184

Git commit 2cb62c72b9975d85c86e303ff6d5df8e6e5957c5 by Plata Hill.
Committed on 21/12/2024 at 12:55.
Pushed by plata into branch 'master'.

TV Spielfilm fetcher: fix program stop time before start time

It can happen that the stop time of a program is incorrect (i.e. after the next program has already started).
In this case, TV Spielfilm fetcher overwrites the stop time with the start time of the next program.

As days are fetched from future to past to be able to stop early,
the last program of the next day is the "previous" program of the first program of the current day.
When the stop time was "fixed" in this case, it led to empty entries and misaligned times on the "Favorites" page.

Fix the stop time only if the "previous" program is really previous.

Note: To avoid problems like this, it would generally be better to parse in chronological order.
However, this would be at the cost of performance (stopping early no longer possible).
Additionally, the cases where fixing the stop time is necessary are only rare exceptions.

FIXED-IN: 24.12.1

M  +4    -1    src/tvspielfilmfetcher.cpp

https://invent.kde.org/utilities/telly-skout/-/commit/2cb62c72b9975d85c86e303ff6d5df8e6e5957c5

Git commit 5af350212d08ca5eaf65213143ad9178ce7c66b3 by Plata Hill.
Committed on 21/12/2024 at 12:57.
Pushed by plata into branch 'release/24.12'.

TV Spielfilm fetcher: fix program stop time before start time

It can happen that the stop time of a program is incorrect (i.e. after the next program has already started).
In this case, TV Spielfilm fetcher overwrites the stop time with the start time of the next program.

As days are fetched from future to past to be able to stop early,
the last program of the next day is the "previous" program of the first program of the current day.
When the stop time was "fixed" in this case, it led to empty entries and misaligned times on the "Favorites" page.

Fix the stop time only if the "previous" program is really previous.

Note: To avoid problems like this, it would generally be better to parse in chronological order.
However, this would be at the cost of performance (stopping early no longer possible).
Additionally, the cases where fixing the stop time is necessary are only rare exceptions.

FIXED-IN: 24.12.1

M  +4    -1    src/tvspielfilmfetcher.cpp

https://invent.kde.org/utilities/telly-skout/-/commit/5af350212d08ca5eaf65213143ad9178ce7c66b3

Thank you! Build and installed package for commit 5af350212d08ca5eaf65213143ad9178ce7c66b3, launched Telly Skout, refetched and so far everything seems to be ok.