| Summary: | episode's length is shown 0:00:00 but the audio file is not-null length | ||
|---|---|---|---|
| Product: | [Applications] kasts | Reporter: | Marco Mattiolo <marco.mattiolo> |
| Component: | general | Assignee: | bart |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | 24.08.3 | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/multimedia/kasts/-/commit/e67b9ed3bbbfc52b5c835981cebbf4a2635d4d41 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
screenshot showing Kasts queue page with the issue
screenshot with Kasts patched with relevant MR |
||
|
Description
Marco Mattiolo
2024-12-14 10:07:22 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/kasts/-/merge_requests/206 The issue here is that the duration of the enclosure is supposed to be set correctly in the rss feed entry itself. So the ultimate solution is to get the author to set the duration correctly in the feed in the first place. If the author hasn't done that, there is no way of knowing the length of the episode until you have actually retrieved the file. However, we can of course update the duration once an episode has been downloaded. The current version of Kasts does that when you start playing the file. I've just opened an MR to already probe for the duration as soon as the file has been downloaded, which would already help a lot. Unfortunately, it seems that a lot of people are directly streaming episodes rather than downloading them first. For those situations, there is no solution: the wrong duration will be shown until they start playing the file. (I don't want to start probing/streaming every entry in a list just to get the duration. You would probably get banned for DoSing the service.) Git commit e77f317f911ddad40f9592994ba66150aaaccac9 by Bart De Vries. Committed on 15/12/2024 at 18:51. Pushed by bdevries into branch 'master'. Retrieve duration from file as soon as it's downloaded This will replace the less reliable duration as retrieved from the rss feed entry. M +11 -1 src/enclosure.cpp https://invent.kde.org/multimedia/kasts/-/commit/e77f317f911ddad40f9592994ba66150aaaccac9 Created attachment 176663 [details]
screenshot with Kasts patched with relevant MR
Hi, sorry it took me so long to build the patched Kasts to check the fix: yes, the actual length of the episode is now shown (thank you!), but the value of the remaining time to be played isn't updated until the app is restarted. It would make sense that a recalculation of the remaining play time is triggered when an episode is downloaded. But we're now down in the details' realm, it's not a big issue anyway...
I'm pretty sure that the remaining time will also get immediately updated as soon as you start playing *any* episode. Anytime any play position changes, that remaining time gets updated. That should happen about every second when playing. I think that should be sufficient? Could you perhaps check that my statement is indeed correct at your end? Git commit e67b9ed3bbbfc52b5c835981cebbf4a2635d4d41 by Bart De Vries. Committed on 15/12/2024 at 20:22. Pushed by bdevries into branch 'release/24.12'. Retrieve duration from file as soon as it's downloaded This will replace the less reliable duration as retrieved from the rss feed entry. M +11 -1 src/enclosure.cpp https://invent.kde.org/multimedia/kasts/-/commit/e67b9ed3bbbfc52b5c835981cebbf4a2635d4d41 (In reply to bart from comment #5) > I'm pretty sure that the remaining time will also get immediately updated as > soon as you start playing *any* episode. Anytime any play position changes, > that remaining time gets updated. That should happen about every second > when playing. I think that should be sufficient? > > Could you perhaps check that my statement is indeed correct at your end? AmpHour is the only podcast with this issue, then I should wait for their next episode to be available. But I trust your experience, so I will call this fixed! ;) |