Bug 497251

Summary: Kirigami.Icon highlight effect doesn't really work for light-colored icons
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Fernando M. Muniz <fernandommuniz>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs-null>
Status: CONFIRMED ---    
Severity: minor CC: materka, nate, notmart
Priority: NOR    
Version First Reported In: 6.9.0   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Notice how the battery gets highlighted, but the other system icons do not (ignore the OBS ones).

Description Fernando M. Muniz 2024-12-09 23:00:51 UTC 
When hovering over the battery widget's charging icon, the green plug gains a white highlight over it.
This is something that other widget icons lack, including the battery while not charging.

So either that highlight is actually a bug, or all other widget icons are inconsistent.
Comment 1 Nate Graham 2024-12-10 22:55:29 UTC 
Works as expected for me. Can you attach a screen recording that shows the issue happening?
Comment 2 Fernando M. Muniz 2024-12-11 00:32:43 UTC 
Created attachment 176510 [details]
Notice how the battery gets highlighted, but the other system icons do not (ignore the OBS ones).
Comment 3 Nate Graham 2024-12-11 17:14:17 UTC 
The issue here is with Kirigami.Icon's highlight effect. It works as expected with a light theme and dark icons, but does not work as well with the reverse. This is because it tries to lighten colors, but the light icons are already pretty much as light as they can be — except for parts of them that are other colors, like the green plug in the battery icon, and the red slash in the mute icon. So only those parts get lightened.