Summary: | String status in .ts files is unusable | ||
---|---|---|---|
Product: | [Applications] lokalize | Reporter: | Yaron Shahrabani <sh.yaron> |
Component: | general | Assignee: | Simon Depiets <sdepiets> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aacid, sh.yaron, shafff |
Priority: | NOR | ||
Version First Reported In: | 24.08.3 | ||
Target Milestone: | --- | ||
Platform: | Manjaro | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/sdk/lokalize/-/commit/56cfc8f0a938a000cf36bc74e43ef3830e5152dc | Version Fixed In: | |
Sentry Crash Report: |
Description
Yaron Shahrabani
2024-12-02 06:06:33 UTC
A possibly relevant merge request was started @ https://invent.kde.org/sdk/lokalize/-/merge_requests/189 Git commit 3c294d0b504f8c15a476213d15d900be0ec9d676 by Albert Astals Cid. Committed on 03/12/2024 at 18:54. Pushed by aacid into branch 'master'. Make TsStorage/XliffStorage::isEmpty work again In e7f783daddd813128aed9ef8c4fd6c092d56096d the condition - || (!result.isEmpty() && data && data->actionType == ContentEditingData::CheckLength)) was changed to + || (data && data->actionType == ContentEditingData::CheckLength)) on the basis that result.isEmpty was always false Well then then correct change is to remove the || altogether not to remove the code that is turning that check into false M +1 -1 src/catalog/ts/tsstorage.cpp M +1 -1 src/catalog/xliff/xliffstorage.cpp https://invent.kde.org/sdk/lokalize/-/commit/3c294d0b504f8c15a476213d15d900be0ec9d676 Git commit 56cfc8f0a938a000cf36bc74e43ef3830e5152dc by Albert Astals Cid. Committed on 03/12/2024 at 19:01. Pushed by aacid into branch 'release/24.12'. Make TsStorage/XliffStorage::isEmpty work again In e7f783daddd813128aed9ef8c4fd6c092d56096d the condition - || (!result.isEmpty() && data && data->actionType == ContentEditingData::CheckLength)) was changed to + || (data && data->actionType == ContentEditingData::CheckLength)) on the basis that result.isEmpty was always false Well then then correct change is to remove the || altogether not to remove the code that is turning that check into false (cherry picked from commit 3c294d0b504f8c15a476213d15d900be0ec9d676) M +1 -1 src/catalog/ts/tsstorage.cpp M +1 -1 src/catalog/xliff/xliffstorage.cpp https://invent.kde.org/sdk/lokalize/-/commit/56cfc8f0a938a000cf36bc74e43ef3830e5152dc |