| Summary: | compile error in kmessagewidgettest.cpp | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kwidgetsaddons | Reporter: | Glenn Burkhardt <gbburkhardt> |
| Component: | general | Assignee: | Christoph Feck <cfeck> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | john.kizer, kdelibs-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | 6.8.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
Well, probably remove the
delete mainWindow;
line.
Hi - am I reading correctly that you've identified a patch for the issue you're describing? If so, that's fantastic! To make sure it gets applied and isn't missed, could you please submit this patch as a merge request using GitLab? (https://community.kde.org/Infrastructure/GitLab) Thanks! (In reply to Glenn Burkhardt from comment #0) > SUMMARY > C:/Users/glenn/msys2/kde-frameworks/kwidgetsaddons-6.8.0/tests/ > kmessagewidgettest.cpp:110:1: error:control reaches end of non-void function > [-Werror=return-type] > 110 | } > | ^ > > > STEPS TO REPRODUCE > 1. > 2. > 3. > > OBSERVED RESULT > > > EXPECTED RESULT > > > SOFTWARE/OS VERSIONS > Windows: 11 > gcc.exe (Rev1, Built by MSYS2 project) 14.2.0 > > ADDITIONAL INFORMATION > Just swap the last two lines to fix. > > Users/glenn/msys2/kde-frameworks/kwidgetsaddons-6.8.0/tests/ > kmessagewidgettest.cpp > *** > C:/Users/glenn/msys2/kde-frameworks/kwidgetsaddons-6.8.0/tests/ > kmessagewidgettest.cpp~ Sat Nov 2 11:49:43 2024 > --- > C:/Users/glenn/msys2/kde-frameworks/kwidgetsaddons-6.8.0/tests/ > kmessagewidgettest.cpp Tue Nov 26 13:17:38 2024 > *************** > *** 105,112 **** > Receiver *info = new Receiver(mw); > QObject::connect(mw, &KMessageWidget::linkActivated, info, > &Receiver::showWhatsThis); > > - return app.exec(); > delete mainWindow; > } > > #include "kmessagewidgettest.moc" > --- 105,112 ---- > Receiver *info = new Receiver(mw); > QObject::connect(mw, &KMessageWidget::linkActivated, info, > &Receiver::showWhatsThis); > > delete mainWindow; > + return app.exec(); > } > > #include "kmessagewidgettest.moc" Clearly this isn't right. The main window shouldn't be deleted before the 'app.exec()' call. Probably just remove the "delete mainWindow;" line. 🐛🧹 ⚠️ This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information, then set the bug status to REPORTED. If there is no change for at least 30 days, it will be automatically closed as RESOLVED WORKSFORME. For more information about our bug triaging procedures, please read https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging. Thank you for helping us make KDE software even better for everyone! 🐛🧹 This bug has been in NEEDSINFO status with no change for at least 30 days. Closing as RESOLVED WORKSFORME. |
SUMMARY C:/Users/glenn/msys2/kde-frameworks/kwidgetsaddons-6.8.0/tests/kmessagewidgettest.cpp:110:1: error:control reaches end of non-void function [-Werror=return-type] 110 | } | ^ STEPS TO REPRODUCE 1. 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: 11 gcc.exe (Rev1, Built by MSYS2 project) 14.2.0 ADDITIONAL INFORMATION Just swap the last two lines to fix. Users/glenn/msys2/kde-frameworks/kwidgetsaddons-6.8.0/tests/kmessagewidgettest.cpp *** C:/Users/glenn/msys2/kde-frameworks/kwidgetsaddons-6.8.0/tests/kmessagewidgettest.cpp~ Sat Nov 2 11:49:43 2024 --- C:/Users/glenn/msys2/kde-frameworks/kwidgetsaddons-6.8.0/tests/kmessagewidgettest.cpp Tue Nov 26 13:17:38 2024 *************** *** 105,112 **** Receiver *info = new Receiver(mw); QObject::connect(mw, &KMessageWidget::linkActivated, info, &Receiver::showWhatsThis); - return app.exec(); delete mainWindow; } #include "kmessagewidgettest.moc" --- 105,112 ---- Receiver *info = new Receiver(mw); QObject::connect(mw, &KMessageWidget::linkActivated, info, &Receiver::showWhatsThis); delete mainWindow; + return app.exec(); } #include "kmessagewidgettest.moc"