Bug 496633

Summary:	label and context strings are interchanged in screencast.cpp
Product:	[Plasma] xdg-desktop-portal-kde	Reporter:	Kishore Gopalakrishnan <kishore96>
Component:	general	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aleixpol
Priority:	NOR
Version First Reported In:	git-master
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:	https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/276fd3963c51c6407775eccab196e91b896f7298	Version Fixed/Implemented In:
Sentry Crash Report:

Description Kishore Gopalakrishnan 2024-11-24 11:14:49 UTC

The first argument of i18nc is the context ( https://techbase.kde.org/Development/Tutorials/Localization/i18n#Adding_Context_with_i18nc() ). The strings seem to be interchanged at https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/blob/master/src/screencast.cpp?ref_type=heads#L297 , leading to the context string being shown as the label in the application.

Comment 1 Bug Janitor Service 2024-11-24 18:38:30 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/330

Comment 2 Nicolas Fella 2024-11-24 20:49:25 UTC

Git commit 276fd3963c51c6407775eccab196e91b896f7298 by Nicolas Fella.
Committed on 24/11/2024 at 18:37.
Pushed by nicolasfella into branch 'master'.

Fix i18nc usage

The context is the first arg

M  +1    -1    src/screencast.cpp

https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/276fd3963c51c6407775eccab196e91b896f7298