Bug 496551

Summary: Discover seems to update KNS content successfully, but then the same content is listed as updateable again after a re-launch
Product: [Applications] Discover Reporter: Nate Graham <nate>
Component: KNewStuff BackendAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: major CC: aleixpol, leinir
Priority: NOR    
Version First Reported In: master   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: Frameworks 6.9
Sentry Crash Report:
Attachments: KNS update log

Description Nate Graham 2024-11-21 18:56:46 UTC
Created attachment 176016 [details]
KNS update log

STEPS TO REPRODUCE
1. Have KNS content available for update
2. Launch Discover > Updates > click "Update"
3. Wait for it to finish, then quit Discover
4. Re-launch Discover > Updates


OBSERVED RESULT
The things Discover just told me it successfully updated are still there!


EXPECTED RESULT
Those things are not listed as updateable anymore


ADDITIONAL INFORMATION
Everything KDE from git master. Full debug log of the update transaction attached.
Comment 1 Bug Janitor Service 2024-11-26 11:08:56 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/344
Comment 2 Harald Sitter 2024-11-27 07:10:08 UTC
Git commit 213c7d42328534c0527aaa6ea12b915adc8f6f98 by Harald Sitter.
Committed on 27/11/2024 at 07:05.
Pushed by sitter into branch 'master'.

do not finish the transaction before it actually did anything

this would auto-delete it before the signals from the ctor fire and
consequently the change was never written to the registry making it look
like the install hadn't been carried out when in fact it was

M  +5    -1    src/core/transaction.cpp

https://invent.kde.org/frameworks/knewstuff/-/commit/213c7d42328534c0527aaa6ea12b915adc8f6f98