Bug 496457

Summary: Wheel/middle click on brightness systray icon is not ignored when night light is disabled
Product: [Plasma] plasmashell Reporter: Elias Probst <mail>
Component: Brightness and Color widgetAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: natalie_clarius, nate
Priority: NOR    
Version First Reported In: master   
Target Milestone: 1.0   
Platform: NixOS   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/powerdevil/-/commit/82338a361f5eb8a9da4e6d9967d7a6901e651a90 Version Fixed In: 6.2.4
Sentry Crash Report:

Description Elias Probst 2024-11-19 10:52:28 UTC 
SUMMARY
A wheel/middle click on the brightness icon in the systray should suspend/resume the night light scheduling.
When night light isn't even configured & activated, a wheel/middle click still displays the corresponding OSD.

STEPS TO REPRODUCE
1. Start a new Plasma session
2. Don't configure anything related to Night Light
3. Wheel/middle click on the brightness icon in the systray

OBSERVED RESULT
The "Night Light suspended"/"Night Light resumed" OSD is shown.

EXPECTED RESULT
Either no OSD is shown or an OSD with a message like "Configure Night Light to suspend/resume" is shown.

SOFTWARE/OS VERSIONS
Operating System: NixOS 24.11
KDE Plasma Version: 6.2.3
KDE Frameworks Version: 6.8.0
Qt Version: 6.8.0
Kernel Version: 6.6.60 (64-bit)
Graphics Platform: Wayland
Processors: 4 × Intel® Core™ i5-6200U CPU @ 2.30GHz
Memory: 19.4 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 520

ADDITIONAL INFORMATION
Related bugs:
- https://bugs.kde.org/show_bug.cgi?id=487617
Comment 1 Bug Janitor Service 2024-11-19 18:57:00 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/powerdevil/-/merge_requests/467
Comment 2 Nate Graham 2024-11-20 16:14:22 UTC 
Git commit 755f6e3f85abfbbf60b86ac89425033a339dbc6c by Nate Graham, on behalf of Elias Probst.
Committed on 20/11/2024 at 15:53.
Pushed by ngraham into branch 'master'.

applets/brightness: toggle nightlight only, when enabled

It doesn't make sense to toggle the night light and show the
corresponding OSD, as long as night light control is generally disabled.

M  +3    -1    applets/brightness/package/contents/ui/main.qml

https://invent.kde.org/plasma/powerdevil/-/commit/755f6e3f85abfbbf60b86ac89425033a339dbc6c
Comment 3 Nate Graham 2024-11-20 16:40:28 UTC 
Git commit 82338a361f5eb8a9da4e6d9967d7a6901e651a90 by Nate Graham.
Committed on 20/11/2024 at 16:34.
Pushed by ngraham into branch 'Plasma/6.2'.

applets/brightness: toggle nightlight only, when enabled

It doesn't make sense to toggle the night light and show the
corresponding OSD, as long as night light control is generally disabled.


(cherry picked from commit 755f6e3f85abfbbf60b86ac89425033a339dbc6c)

Co-authored-by: Elias Probst <mail@eliasprobst.eu>

M  +3    -1    applets/brightness/package/contents/ui/main.qml

https://invent.kde.org/plasma/powerdevil/-/commit/82338a361f5eb8a9da4e6d9967d7a6901e651a90