Bug 496444

Summary: Horizontal Scroll Bars Missing
Product: [Applications] kdiff3 Reporter: Charlie <cfis>
Component: applicationAssignee: michael <reeves.87>
Status: RESOLVED FIXED    
Severity: normal CC: dura, elydgolden, filip.kendes1, gbburkhardt, s.moderow
Priority: NOR    
Version First Reported In: 1.11.5   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: Version Fixed In: 1.12
Sentry Crash Report:
Attachments: No Horizontal Scroll Bars
Scrollbar broken

Description Charlie 2024-11-19 02:15:04 UTC
Created attachment 175938 [details]
No Horizontal Scroll Bars

On windows 11, the latest version, 1.11.5, does not have horizontal scroll bars. Nor can you use the keyboard to scroll horizontally. You can however scroll vertically.
Comment 1 elydgolden 2024-11-19 09:15:21 UTC
Can confirm on the latest linux version as well (openSUSE Tumbleweed)
Comment 2 Sven Moderow 2024-11-19 11:57:38 UTC
Can confirm this on Windows 11 Pro, Version 1.11.5.
Comment 3 Glenn Burkhardt 2024-11-26 15:37:57 UTC
I have a horizontal scroll bar, but it's not correctly sized for the content.  Horizontal scrolling is broken.
Version 1.11.5 (64 bit).  Windows 11.  GPU is Intel Iris Xe, driver version 31.0.101.5333.

This works on my computer with version 1.9.4b.
Comment 4 Glenn Burkhardt 2024-11-26 15:39:13 UTC
Created attachment 176138 [details]
Scrollbar broken
Comment 5 Glenn Burkhardt 2024-12-02 13:01:22 UTC
Comment on attachment 176138 [details]
Scrollbar broken

I've built 'kdiff3' from the current code in the repository, and the scroll bars for both vertical and horizontal are fine.  So I don't know what to say.  For the build, I used:

msys2 MSYS_NT-10.0-26100 DESKTOP-UH4OPKD 3.4.10.x86_64 2023-12-22 10:06 UTC x86_64 Msys
g++.exe (Rev1, Built by MSYS2 project) 14.2.0
Qt 6.6.1 (built by Msys2)
KDE Framework libraries 6.8.0

Windows 11 Version 24H2 (OS Build 26100.2454)

But it's broken in the 1.11.5 release.  I just tried a nightly build (Version 1.11.70, kdiff3-master-1795-windows-cl-msvc2022-x86_64.exe), and both scroll bars are there and function properly.
Comment 6 Charlie 2024-12-22 03:57:35 UTC
The new release, 1.12.0, is better but not fully fixed. This is tested on Windows.

On the good side - the horizontal scrollbar is back and works with the keyboard.  It also works with a mouse.

On the bad side - it does not work with a touchpad. Two finger scrolling works vertically, but still does not work horizontally.

Can that functionality be added back in? Its surprisingly annoying not being able to use the touchpad to scroll horizontally.

Thanks!
Comment 7 michael 2024-12-22 21:08:19 UTC
1.12.1 will fix the track pad response. Looks like the reset seems to be resolved in 1.12.0
Comment 8 michael 2024-12-22 21:09:18 UTC
1.12.1 will fix the track pad response. Looks like the reset seems to be resolved in 1.12.0
Comment 9 Charlie 2025-02-17 01:40:36 UTC
Any timeline on 1.12.1? Would be nice to scroll with the trackpad again.
Comment 10 michael 2025-02-17 21:04:34 UTC
With in the next couple days assuming nothing weird happens.
Comment 11 Charlie 2025-02-26 03:56:29 UTC
Thanks for the release! Any chance of a windows build?
Comment 12 michael 2025-02-26 12:15:28 UTC
They are up now usually a 24 hour delay to insure they get the right version number. https://download.kde.org/stable/kdiff3/kdiff3-1.12.0-windows-cl.exe.mirrorlist
Be advised Windows 11 likes to auto hide the scrollbars and/or draw them really small. I haven't seen anything in the Qt API that can control this but the scroll should work.
Comment 13 Charlie 2025-02-26 17:41:56 UTC
Hmm, I was looking here - https://download.kde.org/stable/kdiff3/. I see a 1.12.1 release from February 17th, but not binary builds.
Comment 14 michael 2025-03-01 15:04:56 UTC
Looks it wasn't actually sent to be published fixed now.
Comment 15 dura 2025-06-24 21:16:13 UTC
This bug is back again in 1.12.3 and master with commit 47195bf81c7f182ba41ecfadd9cf86664e0d884f (Short curcuit DiffTextWindow::getMaxTextWidth for early init calls). The horizontal scroll bar is here but not usable like in Glenn Burkhardt screenshot. Reverting the commit on master or 1.12.3 make the scroll bar working again.
Comment 16 michael 2025-06-27 00:29:02 UTC
Strange I'm not sure why that would have broken the scrollbar.
Comment 17 dura 2025-06-27 16:19:56 UTC
The change you made in the commit is not consistent with the previous version.
It should be:
if(d->mDiff3LineVector == nullptr || d->m_bWordWrap)
instead of:
if(d->mDiff3LineVector == nullptr || !d->m_bWordWrap)
You must remove the "!".
Comment 18 michael 2025-07-02 16:32:24 UTC
Found it corrected.