Bug 496434

Summary: Context Menu Web Shortcuts Not Functional on Neochat
Product: [Applications] NeoChat Reporter: Timothy Arnold <timaeos>
Component: GeneralAssignee: Joshua Goins <josh>
Status: RESOLVED FIXED    
Severity: normal CC: carl, josh
Priority: NOR    
Version First Reported In: git master   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/network/neochat/-/commit/5b935c1d33197d3e1217f6bb9819b894df240702 Version Fixed/Implemented In:
Sentry Crash Report:

Description Timothy Arnold 2024-11-18 19:27:46 UTC 
SUMMARY
On NeoChat Master (using kdesrc-build), the context menu web shortcuts are no longer functioning

STEPS TO REPRODUCE
1. Log into NeoChat
2. Open a Chat
3. Highlight text in a message
4. Right-Click to open the context menu
5. Highlight the "Search for ..." selection
6. Select a web shortcut

OBSERVED RESULT
The web browser doesn't open as expected for the context menu web shortcut

EXPECTED RESULT
A web browser should open with the corresponding web shortcut 

SOFTWARE/OS VERSIONS
Neochat:
NeoChat: 25.03.70
KDE Frameworks: 6.9.0
Qt: Using 6.8.0 and built against 6.8.0
Fedora Linux 41 (KDE Plasma) (Wayland)
libQuotient: 0.9.0 (built against 0.9.0)
Build ABI: x86_64-little_endian-lp64
Kernel: linux 6.11.7-300.fc41.x86_64




Operating System: Fedora Linux 41
KDE Plasma Version: 6.2.3
KDE Frameworks Version: 6.8.0
Qt Version: 6.8.0
Kernel Version: 6.11.7-300.fc41.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 16 × AMD Ryzen 7 2700X Eight-Core Processor
Memory: 31.3 GiB of RAM
Graphics Processor: AMD Radeon RX 590 Series


ADDITIONAL INFORMATION
Comment 1 Bug Janitor Service 2024-12-13 19:46:34 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/2053
Comment 2 Carl Schwan 2024-12-14 09:34:15 UTC 
Git commit 23eaa6a4c75b2e19d1ee78d8091143e3b5cd7aa9 by Carl Schwan, on behalf of Joshua Goins.
Committed on 14/12/2024 at 09:26.
Pushed by carlschwan into branch 'master'.

Fix web shortcuts not doing anything

This is because we're passing a QUrl into a QString, we need to turn it
into a string explicitly.

M  +1    -1    src/qml/DelegateContextMenu.qml

https://invent.kde.org/network/neochat/-/commit/23eaa6a4c75b2e19d1ee78d8091143e3b5cd7aa9
Comment 3 Joshua Goins 2024-12-15 13:36:48 UTC 
Git commit 5b935c1d33197d3e1217f6bb9819b894df240702 by Joshua Goins.
Committed on 15/12/2024 at 12:55.
Pushed by redstrate into branch 'release/24.12'.

Fix web shortcuts not doing anything

This is because we're passing a QUrl into a QString, we need to turn it
into a string explicitly.
(cherry picked from commit 23eaa6a4c75b2e19d1ee78d8091143e3b5cd7aa9)

M  +1    -1    src/qml/DelegateContextMenu.qml

https://invent.kde.org/network/neochat/-/commit/5b935c1d33197d3e1217f6bb9819b894df240702