Bug 496329

Summary:	Discover allows to write reviews for Flatpak runtimes
Product:	[Applications] Discover	Reporter:	Nicolas Fella <nicolas.fella>
Component:	Flatpak Backend	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	4wy78uwh, aleixpol, jgrulich, nate, travier
Priority:	NOR	Keywords:	usability
Version First Reported In:	master
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/discover/-/commit/f8681aa9128607887ae6e5ae2e404efe0d7e6815	Version Fixed/Implemented In:	6.2.4
Sentry Crash Report:

Description Nicolas Fella 2024-11-16 01:02:21 UTC

STEPS TO REPRODUCE
1. Open Discover 
2. Go to "Installed"
3. Click on e.g. "KDE Application Platform"

OBSERVED RESULT
A page opens where I am shown reviews from people and can write my own review

EXPECTED RESULT
Flatpak runtimes are implementation details that users are not allowed to have an opinion on, so publicly reviewing them makes no sense

SOFTWARE/OS VERSIONS
KDE Plasma Version: master
KDE Frameworks Version: master
Qt Version: 6.8

ADDITIONAL INFORMATION

Comment 1 Bug Janitor Service 2024-11-19 21:27:35 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/973

Comment 2 Nate Graham 2024-11-25 00:41:35 UTC

Git commit c7738e4871bee320c03a95dc8452a4263ea1053e by Nate Graham.
Committed on 25/11/2024 at 00:41.
Pushed by ngraham into branch 'master'.

Hide irrelevant stuff for Flatpak runtimes

It doesn't make sense to be able to write reviews for Flatpak runtimes,
try to load screenshots, allow configuring permissions, and things like
that. Let's hide this stuff.
Related: bug 496330
FIXED-IN: 6.2.4

M  +12   -8    discover/qml/ApplicationPage.qml
M  +5    -1    libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
M  +1    -0    libdiscover/resources/AbstractResource.h

https://invent.kde.org/plasma/discover/-/commit/c7738e4871bee320c03a95dc8452a4263ea1053e

Comment 3 Nate Graham 2024-11-25 00:49:16 UTC

Git commit f8681aa9128607887ae6e5ae2e404efe0d7e6815 by Nate Graham.
Committed on 25/11/2024 at 00:48.
Pushed by ngraham into branch 'Plasma/6.2'.

Hide irrelevant stuff for Flatpak runtimes

It doesn't make sense to be able to write reviews for Flatpak runtimes,
try to load screenshots, allow configuring permissions, and things like
that. Let's hide this stuff.
Related: bug 496330
FIXED-IN: 6.2.4
(cherry picked from commit c7738e4871bee320c03a95dc8452a4263ea1053e)

M  +12   -8    discover/qml/ApplicationPage.qml
M  +5    -1    libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
M  +1    -0    libdiscover/resources/AbstractResource.h

https://invent.kde.org/plasma/discover/-/commit/f8681aa9128607887ae6e5ae2e404efe0d7e6815

Comment 4 Roke Julian Lockhart Beedell 2024-11-30 12:35:05 UTC

I really don't see the problem with allowing users to rate these. Microsoft permits it at their `msstore` repository (via the `Microsoft.WindowsStore` package). Reviews tend to be summarisations of a user's experience with a package that can't easily be separated into individual issues in the upstream tracker. That applies to a runtime as much anything else, if that runtime has been problematic or impressive for the reviewer.

On that note, might I ask what you mean by "Flatpak runtimes are implementation details that users are not allowed to have an opinion on"?