Bug 496328

Summary: Switching between Flatpak sources opens the wrong thing
Product: [Applications] Discover Reporter: Nicolas Fella <nicolas.fella>
Component: discoverAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: aleixpol, chocolateimage, nate, therealuser8395
Priority: HI Keywords: regression
Version First Reported In: master   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/discover/-/commit/8da790225aaca351e18ae71c4fd5d6cbebfd010c Version Fixed/Implemented In:
Sentry Crash Report:

Description Nicolas Fella 2024-11-16 00:56:38 UTC 
STEPS TO REPRODUCE
1. On KDE Linux open Discover
2. Search for Neochat
3. On Neochat's page click on "From Flathub" in the toolbar.

OBSERVED RESULT
A menu with two "Flathub" entries appears. Clicking on the unselected one opens the page for "KDE Application Platform"

EXPECTED RESULT
Not that. There probaby shouldn't be two "Flathub" entries in the first place

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE Linux 202411150323
KDE Plasma Version: master-ish?
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2024-11-19 19:16:15 UTC 
Can confirm. Looks like a somewhat recent regression. I don't recall this happening a week or two ago.
Comment 2 Nicolas Fella 2024-11-19 19:21:22 UTC 
I haven't tested, but I'd suspect https://invent.kde.org/plasma/discover/-/merge_requests/970
Comment 3 chocolateimage 2024-11-30 12:42:51 UTC 
I also got this problem when testing out KDE neon unstable. The sources list seems to get even larger and larger when scrolling through apps (resize Discover to get both the app list and app info at the same time).
Could be related to https://invent.kde.org/plasma/discover/-/merge_requests/944
Comment 4 Nate Graham 2024-12-03 16:41:25 UTC Comment hidden (spam)
Comment 5 Nate Graham 2024-12-03 16:44:51 UTC Comment hidden (spam)
Comment 6 Nate Graham 2024-12-03 17:12:26 UTC 
Harald discovered that https://invent.kde.org/plasma/discover/-/commit/0f513329ae5f83ef969b38cf18b3469d0b8fc60d caused this, and I can confirm that.
Comment 7 Bug Janitor Service 2024-12-04 02:37:44 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/979
Comment 8 Nate Graham 2024-12-10 22:56:54 UTC 
*** Bug 497254 has been marked as a duplicate of this bug. ***
Comment 9 Nate Graham 2024-12-13 16:36:53 UTC 
Git commit 8da790225aaca351e18ae71c4fd5d6cbebfd010c by Nate Graham, on behalf of Aleix Pol.
Committed on 13/12/2024 at 16:30.
Pushed by ngraham into branch 'master'.

Revert "ResourcesProxyModel: integrate resources that aren't part of the model"

This reverts commit 0f513329ae5f83ef969b38cf18b3469d0b8fc60d.
It breaks the premise that only the backend can tell which resources
belong to a query. Will have to address the bug in a different way.
Related: bug 493790

M  +1    -5    libdiscover/resources/ResourcesProxyModel.cpp

https://invent.kde.org/plasma/discover/-/commit/8da790225aaca351e18ae71c4fd5d6cbebfd010c