Bug 495948

Summary: Regression: Underline/highlight missing for Speed/Details in Networks panel
Product: [Plasma] plasma-nm Reporter: dofficialgman
Component: appletAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: nate, niccolo.venerandi, sitter
Priority: NOR Keywords: regression
Version: 6.2.3   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In: 6.3.0
Sentry Crash Report:

Description dofficialgman 2024-11-08 02:24:30 UTC
SUMMARY
The underline/highlight that was previously there when selecting speed/details in the networks panel has gone missing. Now it is not possible to tell which section (speed or details) the user has selected

STEPS TO REPRODUCE
1. Click "Networks" from the panel
2. Click "Expand" on a network
3. Observe Speed/Details have no highlight/underline

OBSERVED RESULT
Observe Speed/Details have no highlight/underline

EXPECTED RESULT
Observe Speed/Details have the highlight/underline from before (I do not recall which it had)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE neon 6.2
KDE Plasma Version: 6.2.3
KDE Frameworks Version: 6.7.0
Qt Version: 6.8.0

ADDITIONAL INFORMATION
I believe this to be a regression from Plasma 6.2.2
Comment 1 Nate Graham 2024-11-08 21:42:18 UTC
You're right!
Comment 2 Harald Sitter 2024-11-21 12:02:44 UTC
https://bugreports.qt.io/browse/QTBUG-131445
Comment 3 Bug Janitor Service 2024-11-21 12:04:13 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/387
Comment 4 Harald Sitter 2024-11-27 07:38:39 UTC
Git commit 8291489f1be51652418f2f6122626c6b2f6d4f13 by Harald Sitter.
Committed on 27/11/2024 at 07:36.
Pushed by sitter into branch 'master'.

connectionitem: delay tabbar height binding till after completion

slightly complicated interaction of bugs here. something inside tabbar,
listview, or listview highlight is buggy such that the highlight breaks
when the initial height is 0.

to work around the problem we set the initial height to the
implicitHeight (i.e. the contentHeight) and only install a binding that
may be 0 when the component is complete. effectively delaying the
zeroness.

this should ensure the tab highlight appears in all Qt versions

https://bugreports.qt.io/browse/QTBUG-131445

M  +7    -1    applet/contents/ui/ConnectionItem.qml

https://invent.kde.org/plasma/plasma-nm/-/commit/8291489f1be51652418f2f6122626c6b2f6d4f13