Bug 495597

Summary:	Reviews UI not shown on app pages accessed from home screen
Product:	[Applications] Discover	Reporter:	Nate Graham <nate>
Component:	discover	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aleixpol
Priority:	NOR	Keywords:	regression
Version:	master
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/discover/-/commit/9baf50fca7a37f5bed750a706f32d5c7f9528f1e	Version Fixed In:
Sentry Crash Report:

Description Nate Graham 2024-10-30 16:50:27 UTC

STEPS TO REPRODUCE
1.  Launch Discover
2. Click on any app on the home page
3. Scroll down

OBSERVED RESULT
No reviews UI

EXPECTED RESULT
Reviews UI

ADDITIONAL INFORMATION
The reviews UI shows up on app pages when apps are invokes from a browse or search list.

Comment 1 Bug Janitor Service 2024-10-30 23:20:08 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/962

Comment 2 Aleix Pol 2024-11-01 17:05:58 UTC

Git commit 1d1210aadd9bccc033111cf31d133be59bbcacfb by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 01/11/2024 at 17:01.
Pushed by apol into branch 'master'.

ApplicationPage: Fix visibility of the reviews component

Do not make the visibility of a parent item depend on its children's as
if it affects them.
Also address the logic, it was weird. We need to show it if we are
fetching, if we fetched and didn't find anything or if we are trying to
show an error.

M  +3    -2    discover/qml/ApplicationPage.qml

https://invent.kde.org/plasma/discover/-/commit/1d1210aadd9bccc033111cf31d133be59bbcacfb

Comment 3 Aleix Pol 2024-11-01 18:09:09 UTC

Git commit 9baf50fca7a37f5bed750a706f32d5c7f9528f1e by Aleix Pol Gonzalez.
Committed on 01/11/2024 at 17:21.
Pushed by apol into branch 'Plasma/6.2'.

ApplicationPage: Fix visibility of the reviews component

Do not make the visibility of a parent item depend on its children's as
if it affects them.
Also address the logic, it was weird. We need to show it if we are
fetching, if we fetched and didn't find anything or if we are trying to
show an error.


(cherry picked from commit 1d1210aadd9bccc033111cf31d133be59bbcacfb)

Co-authored-by: Aleix Pol <aleixpol@kde.org>

M  +3    -2    discover/qml/ApplicationPage.qml

https://invent.kde.org/plasma/discover/-/commit/9baf50fca7a37f5bed750a706f32d5c7f9528f1e