Bug 494906

Summary: Allow tooltips to control audio regardless of what 'Mark applications that play audio' is set to.
Product: [Plasma] plasmashell Reporter: pmargeti34
Component: Task Manager and Icons-Only Task ManagerAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: wishlist CC: nate, qydwhotmail
Priority: NOR    
Version: git-stable-Plasma/6.2   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 6.3.0
Sentry Crash Report:
Attachments: Desired outcome: tooltip Volume controls are always displayed

Description pmargeti34 2024-10-17 03:20:01 UTC
Created attachment 174929 [details]
Desired outcome: tooltip Volume controls are always displayed

SUMMARY
Please allow tooltips to control audio regardless of what 'Mark applications that play audio' is set to.

USABILITY
'Mark applications that play audio' overlays a tiny icon in the top right corner of icons only task manager that toggles mute of the audio stream. This audio indicator is prone to accidental clicks when task manager is used to switch between applications.

RATIONALE
Users typically *know* which applications are playing audio. Mute and Volume controls only appears if 'Mark applications that play audio' is enabled which adds the potentially undesired overlay icon. Currently it's all or nothing.

EXAMPLE SCENARIO
User launches audio player and a video game. User wants to make the game quieter to listen to music while gaming. User accidentally clicks on the overlayed indicator and mutes the game instead of switching to it. Workaround is to turn off 'Mark applications that play audio' but now the volume can't be adjusted from taskbar tooltips anymore.

PROPOSAL
- *Always* display volume controls in application tooltip (if the application is playing audio)  regardless of what 'Mark applications that play audio' is set to.
- Add mute functionality to middle click options for task manager items (e.g. 'Middle-clicking any task: Mutes the audio stream'.
Comment 1 Bug Janitor Service 2024-10-17 05:11:43 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2590
Comment 2 Nate Graham 2024-11-05 17:29:18 UTC
Git commit 3baa5b81d649b85fa2b4f81c0e41fc113e9ff2a2 by Nate Graham, on behalf of Petar Margetic.
Committed on 05/11/2024 at 17:29.
Pushed by ngraham into branch 'master'.

applets/taskmanager: Make task mute icon optionally interactive

"Mark applications that play audio" causes issues with accidental muting when
the Task Manager is in icons-only mode. 

Changes summary:
- Let the overlay indicator and task preview volume controls always be
  displayed. 
- Allow configuring the audio overlay indicator to be interactive mute via
  a new "[] Use audio indicators to mute tasks" setting
- Remove the now superfluous old "[] Mark applications that play audio"
  setting. 

Work presented here is based on input of VDG and interested third parties.
FIXED-IN: 6.3.0

M  +2    -2    applets/taskmanager/package/contents/config/main.xml
M  +3    -0    applets/taskmanager/package/contents/ui/AudioStream.qml
M  +5    -5    applets/taskmanager/package/contents/ui/ConfigAppearance.qml
M  +2    -2    applets/taskmanager/package/contents/ui/Task.qml
M  +0    -1    applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/3baa5b81d649b85fa2b4f81c0e41fc113e9ff2a2