| Summary: | Highlight when selected text matches other texts for Breeze Dark has low visibility | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-syntax-highlighting | Reporter: | EpicTux123 <EpicTux123> |
| Component: | theme | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | christoph, waqar.17a |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=495070 | ||
| Latest Commit: | https://invent.kde.org/frameworks/syntax-highlighting/-/commit/fbc3eacc344b201cc584cd9b976163841ddf67a3 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | matched text highlighting | ||
True. SearchHighlight leads to bad contrast. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/667 Git commit fbc3eacc344b201cc584cd9b976163841ddf67a3 by Waqar Ahmed, on behalf of Christoph Cullmann. Committed on 19/10/2024 at 20:18. Pushed by cullmann into branch 'master'. better contrast for search highlighting M +2 -2 data/themes/breeze-dark.theme https://invent.kde.org/frameworks/syntax-highlighting/-/commit/fbc3eacc344b201cc584cd9b976163841ddf67a3 Thanks for the fix. However, I believe the new color (#414857) does not have a very good contrast since the background is dark. I think a new color should be considered for better and fast eye-catch on highlighted matches. (In reply to EpicTux123 from comment #5) > Thanks for the fix. > > However, I believe the new color (#414857) does not have a very good > contrast since the background is dark. I think a new color should be > considered for better and fast eye-catch on highlighted matches. If you have a concrete proposal, that can be tried. But I don't think a much lighter more catchy color is easy to have that will not clash with the highlighting colors. if you have a improved variant, please try to create some before/after shots like in https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/667 The main issue is solved so the bug can stay closed. MRs are welcome if you have a better color idea. |
Created attachment 174741 [details] matched text highlighting When using default Breeze Dark theme on Kate, texts that match the selected text have low visibility. In this case, the ones that match are the problematic ones, because they have green background with blue text, which makes it harder to see. The problem is probably the fact that the matched text turns blue after being selected, instead of remaining white like the first one that was selected.