Bug 494420

Summary: Dialog: Binding loops for properties "calculatedImplicitHeight" and "value"
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: postix <postix>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: carl, espidev, nate, nepnep, notmart, plasma-bugs-null
Priority: NOR    
Version First Reported In: 6.7.0   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 6.12
Sentry Crash Report:

Description postix 2024-10-10 12:32:44 UTC
SUMMARY

```
systemsettings: qrc:/qt/qml/org/kde/kirigami/dialogs/Dialog.qml:344:18: QML ScrollView: Binding loop detected for property "calculatedImplicitWidth":
                                               qrc:/qt/qml/org/kde/kirigami/dialogs/Dialog.qml:358:9
systemsettings: qrc:/qt/qml/org/kde/kirigami/dialogs/Dialog.qml:344:18: QML ScrollView: Binding loop detected for property "calculatedImplicitWidth":
                                               qrc:/qt/qml/org/kde/kirigami/dialogs/Dialog.qml:358:9
systemsettings: qrc:/qt/qml/org/kde/kirigami/dialogs/Dialog.qml:344:18: QML ScrollView: Binding loop detected for property "calculatedImplicitHeight":
                                               qrc:/qt/qml/org/kde/kirigami/dialogs/Dialog.qml:361:9
systemsettings: qrc:/qt/qml/org/kde/kirigami/dialogs/Dialog.qml:401:33: QML Binding: Binding loop detected for property "value":
                                               qrc:/qt/qml/org/kde/kirigami/dialogs/Dialog.qml:409:13
```

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20241007
KDE Plasma Version: 6.2.0
KDE Frameworks Version: 6.6.0
Qt Version: 6.7.3
Kernel Version: 6.11.2-1-default (64-bit)
Graphics Platform: Wayland
Comment 1 Nate Graham 2025-02-18 20:27:39 UTC
*** Bug 500343 has been marked as a duplicate of this bug. ***
Comment 2 Nate Graham 2025-02-19 20:24:27 UTC
*** Bug 500383 has been marked as a duplicate of this bug. ***
Comment 3 Bug Janitor Service 2025-02-22 22:21:31 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1728
Comment 4 Nate Graham 2025-02-24 12:58:24 UTC
Git commit 8ceb7d2ece0d5f8d4a7022c6d5e8265001a29408 by Nate Graham.
Committed on 24/02/2025 at 12:58.
Pushed by ngraham into branch 'master'.

Dialog: fix width and height binding loops

We're doing a complicated calculation to get the implicit widths and
heights of child items, but this is unnecessary because Qt provides
properties we can use for the same purposes. Let's use them.

Tested every Dialog implementation in System Settings, Info Center,
System Monitor, Discover, NeoChat, and Elisa. I found no regressions
with sizing or visual display in any of them, and the binding loop
warning is now gone.
FIXED-IN: 6.12

cc @mart @carlschwan @nicolasfella

M  +2    -2    src/dialogs/Dialog.qml

https://invent.kde.org/frameworks/kirigami/-/commit/8ceb7d2ece0d5f8d4a7022c6d5e8265001a29408