Bug 494399

Summary: Category icons in Kickoff are of the wrong type/color with Breeze Dark icon theme
Product: [Plasma] Breeze Reporter: Alexander M. <apmichalopoulos>
Component: IconsAssignee: visual-design
Status: RESOLVED FIXED    
Severity: normal CC: 4wy78uwh, bizyaev, kainz.a, krorkle, m, mikel5764, nate, noahadvs
Priority: NOR Keywords: regression
Version: 6.2.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 6.8
Sentry Crash Report:
Attachments: Breeze Dark
Breeze Twilight

Description Alexander M. 2024-10-10 09:46:56 UTC
Created attachment 174603 [details]
Breeze Dark

SUMMARY
In Breeze Dark, the category icons in Kickoff are colorful instead of monochrome (see Breeze Dark screenshot).

In Breeze Twilight, the category icons are monochrome but the 'Multimedia' category uses the light variant (see Breeze Twilight screenshot).

STEPS TO REPRODUCE
1. Change the global theme to either Breeze Dark or Breeze Twilight.
2. Open Kickoff and observe results.

OBSERVED RESULT
The icons are wrong: in Breeze Dark they are still colorful, while in Breeze Twilight they are monochrome but the 'Multimedia' category uses the light variant.

EXPECTED RESULT
In both the Breeze Dark and Breeze Twilight themes Kickoff should be using the dark monochrome variants, just like in Breeze it uses the light monochrome variants.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 6.2.0
KDE Frameworks Version: 6.6.0
Qt Version: 6.7.3

ADDITIONAL INFORMATION
These are actually two separate bugs, but they're pretty similar visually and quite possibly technically as well, so I've opted to bundle them into a single bug report.
Comment 1 Alexander M. 2024-10-10 09:47:18 UTC
Created attachment 174604 [details]
Breeze Twilight
Comment 2 Nate Graham 2024-10-10 18:00:20 UTC
Looks like this happens when using Breeze Dark icon theme specifically. Can reproduce. The Breeze Dark global theme switches (unnecessarily) to the Breeze Dark icon theme which is why switching to that triggers it. The Breeze Twilight global theme does not trigger it because it does not switch you to the Breeze Dark icon theme.

So we have two bugs to fix:
1. The Breeze Dark icon theme is broken in this way
2. The Breeze Dark global theme unnecessarily switches to the Breeze Dark icon theme (regular Breeze is fine since the icons re-color as expected).

Let's use this bug report for #1, and I'll open a new one for #2.

The multimedia icon being broken is already fixed in Frameworks 6.7 which will be released tomorrow. Due to disjointed release schedules, unfortunately the fix could not be released before Plasma 6.2.
Comment 3 Nate Graham 2024-10-10 18:15:58 UTC
Damn, I just remembered why it specified the Breeze Dark icon theme specifically: for compatibility with third-party non-KDE apps that support icon theming but don't support our icon recoloring machinery.

...because our icon re-coloring machinery is KDE-specific.

...because there's no standardized spec for how to do icon-recoloring, so icons intended for KDE apps and GTK apps do re-coloring differently.

... because both KDE and GNOME are happy with their own implementations and neither wants to move to the other one.

...because KDE considers GNOME's implementation worse and a hack (which it is) and GNOME barely cares about this topic at all and has no interest in putting resources into improving support for icon theming in general, so their status quo is fine for them.

AKA "why we can't have nice things"

So we can't fix #2 and have to fix #1 and make Breeze Dark do the right thing here.
Comment 4 David Redondo 2024-10-15 08:22:19 UTC
Git commit f062ac004d406c6a927035d05364850c613107f1 by David Redondo.
Committed on 15/10/2024 at 08:02.
Pushed by davidre into branch 'master'.

Sync index.theme changes from breeze to breeze-dark
FIXED-IN:6.8

M  +30   -3    icons-dark/index.theme

https://invent.kde.org/frameworks/breeze-icons/-/commit/f062ac004d406c6a927035d05364850c613107f1