Bug 493803

Summary: Popup width resizes as text changes (e.g. when showing details of a file transfer job)
Product: [Plasma] plasmashell Reporter: Nate Graham <nate>
Component: NotificationsAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: agurenko, kde
Priority: HI Keywords: regression
Version First Reported In: 6.1.90   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=492540
https://bugs.kde.org/show_bug.cgi?id=493737
Latest Commit: Version Fixed/Implemented In: 6.2.0
Sentry Crash Report:
Attachments: Popup width changes as file path shown in the detail section changes

Description Nate Graham 2024-09-29 00:33:11 UTC
Created attachment 174182 [details]
Popup width changes as file path shown in the detail section changes

Fallout from https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4722

See screen recording.
Comment 1 Nate Graham 2024-09-30 15:34:45 UTC
*** Bug 493842 has been marked as a duplicate of this bug. ***
Comment 2 Bug Janitor Service 2024-10-01 08:21:16 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4772
Comment 3 Bug Janitor Service 2024-10-01 09:11:37 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4773
Comment 4 Marco Martin 2024-10-01 10:13:38 UTC
Git commit 158bd86da3dc1b50c09497c0960f7c6de3706034 by Marco Martin.
Committed on 01/10/2024 at 09:11.
Pushed by mart into branch 'Plasma/6.2'.

applets/notifications: Fixes for popup width

* Only consider the size hint of the buttons to eventually enlarge the
  popup
* Make the buttons implicit width surface to the popup via item
  Layout.preferredWidth
* Give the popup Dialog a fixed unresizable width with
  Layout.minimum/maximumWidth to the Dialog main item
Related: bug 493842


(cherry picked from commit 2299a7db4ad205431f13d7d2e80681eacc072e0f)

3fdb2493 applets/notifications: Fixes for popup width

Co-authored-by: Marco Martin <notmart@gmail.com>

M  +6    -0    applets/notifications/package/contents/ui/NotificationItem.qml
M  +6    -2    applets/notifications/package/contents/ui/NotificationPopup.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/158bd86da3dc1b50c09497c0960f7c6de3706034
Comment 5 Marco Martin 2024-10-01 10:14:49 UTC
Git commit 2299a7db4ad205431f13d7d2e80681eacc072e0f by Marco Martin.
Committed on 01/10/2024 at 09:10.
Pushed by mart into branch 'master'.

applets/notifications: Fixes for popup width

* Only consider the size hint of the buttons to eventually enlarge the
  popup
* Make the buttons implicit width surface to the popup via item
  Layout.preferredWidth
* Give the popup Dialog a fixed unresizable width with
  Layout.minimum/maximumWidth to the Dialog main item
Related: bug 493842

M  +6    -0    applets/notifications/package/contents/ui/NotificationItem.qml
M  +6    -2    applets/notifications/package/contents/ui/NotificationPopup.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/2299a7db4ad205431f13d7d2e80681eacc072e0f
Comment 6 Nate Graham 2024-10-01 13:55:43 UTC
*** Bug 493842 has been marked as a duplicate of this bug. ***