| Summary: | Unexpected quick tiling behavior | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Natalie Clarius <natalie_clarius> |
| Component: | Quick Tiling | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ad.liu.jin, m.liu.jin, nate, vlad.zahorodnii |
| Priority: | HI | Keywords: | multiscreen, regression |
| Version First Reported In: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/596ce0b3a08b2fd304b809d923ff21267e25dc65 | Version Fixed In: | 6.3.0 |
| Sentry Crash Report: | |||
|
Description
Natalie Clarius
2024-09-24 22:47:41 UTC
Commit cb86a084 seems relevant, though I haven't yet tested reverting it The result of step 4 is more unexpected than that of step 1 because the window also jumps screens, in the opposite direction of the shortcut pressed. > 1. untiled on left half of left screen (weird)
If a window is already tiled left and you combine (in master/6.3, the semantics are slightly different) it with the opposite action, the result would be no tiling. It's different from 6.2, but I don't think it's weird and there's no definite "this is right" or "this is wrong" in this case.
Regarding the other point in this bug report, yes, we need to fix that.
Not sure what you mean by "the other point"; I think I raised three: 1. Window getting untitled unintuitive (debatable) 2. Window getting moved to screen in the opposite direction unintuitive (maybe again debatable but I find it hard to see how it could be expected) 3. Not possible to tile window to the right, this is clearly a loss of previously working functionality imo > Not sure what you mean by "the other point"
"3. Not possible to tile window to the right"
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/6489 I think it's caused by the window being restored to its original position (before tiling) in the other screen. We can fix it by "restoring" it to a new position in the current screen, or we can do https://invent.kde.org/plasma/kwin/-/merge_requests/6489 so we don't bother with "restoring" at all. IIRC Vlad said "restoring to a new screen" is messy (when discussing launching apps in their previous positions regarding screen layout change), so I'd somewhat prefer the latter. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/6857 Git commit 596ce0b3a08b2fd304b809d923ff21267e25dc65 by Vlad Zahorodnii. Committed on 04/12/2024 at 16:42. Pushed by vladz into branch 'master'. Tweak quick tile shortcut combination algorithm This attempts to provide a compromise between the old and the new quick tiling behavior. With the proposed changes, if a window is tiled so it occupies the left half of the screen and Meta+Right is pressed, the window will occupy the right half of the screen. Quarter tiled windows are tiled as before. If the window is migrated to another screen, it won't be untiled. M +4 -4 autotests/integration/quick_tiling_test.cpp M +5 -0 src/effect/globals.h M +51 -34 src/window.cpp https://invent.kde.org/plasma/kwin/-/commit/596ce0b3a08b2fd304b809d923ff21267e25dc65 |