| Summary: | Overview effect toggles itself off and instantly back on again when set to Meta key | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Akseli Lahtinen <akselmo> |
| Component: | effects-overview | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | aquathing, nate, xaver.hugl |
| Priority: | NOR | ||
| Version: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/1654ddd270849e7c0b093324f5b094cb12d13c88 | Version Fixed In: | 6.2.0 |
| Sentry Crash Report: | |||
|
Description
Akseli Lahtinen
2024-09-24 14:22:57 UTC
Hmm, cannot reproduce with today's git master. can confirm, and I also see why it doesn't happen for Nate. The overview effect gets the keyboard shortcuts on startup, so you need to have the shortcut configured when the effect gets loaded. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/6487 Git commit ff2566562d413dc268d87b3c72fd56a6061a5d40 by Xaver Hugl. Committed on 25/09/2024 at 11:57. Pushed by zamundaaa into branch 'master'. plugins/overview, windowview: don't handle keyboard shortcuts on Wayland The only reason for handling them is that the effect grabs the keyboard, which disables global shortcuts on Xorg. In the Wayland session though, global shortcuts still work while the effects are active, and usually that works fine, as the global shortcuts filter filters out the key press events before they reach the effect. Modifier-only shortcuts though trigger on release, so they don't get filtered out and the shortcut effectively gets triggered twice, once by the effect on press, and once by kglobalacceld on release. M +21 -19 src/plugins/overview/overvieweffect.cpp M +1 -1 src/plugins/windowview/windowvieweffect.cpp https://invent.kde.org/plasma/kwin/-/commit/ff2566562d413dc268d87b3c72fd56a6061a5d40 Git commit 1654ddd270849e7c0b093324f5b094cb12d13c88 by Xaver Hugl. Committed on 25/09/2024 at 19:05. Pushed by zamundaaa into branch 'Plasma/6.2'. plugins/overview, windowview: don't handle keyboard shortcuts on Wayland The only reason for handling them is that the effect grabs the keyboard, which disables global shortcuts on Xorg. In the Wayland session though, global shortcuts still work while the effects are active, and usually that works fine, as the global shortcuts filter filters out the key press events before they reach the effect. Modifier-only shortcuts though trigger on release, so they don't get filtered out and the shortcut effectively gets triggered twice, once by the effect on press, and once by kglobalacceld on release. (cherry picked from commit ff2566562d413dc268d87b3c72fd56a6061a5d40) Co-authored-by: Xaver Hugl <xaver.hugl@gmail.com> M +21 -19 src/plugins/overview/overvieweffect.cpp M +1 -1 src/plugins/windowview/windowvieweffect.cpp https://invent.kde.org/plasma/kwin/-/commit/1654ddd270849e7c0b093324f5b094cb12d13c88 *** Bug 493650 has been marked as a duplicate of this bug. *** |