Bug 493555

Summary:	Effect Zone In/Out time broken when toggle effect zone
Product:	[Applications] kdenlive	Reporter:	Takahiro Kamai <quickle.merci007>
Component:	Video Effects & Transitions	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal	CC:	berndmj
Priority:	NOR
Version First Reported In:	24.08.1
Target Milestone:	---
Platform:	Other
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Takahiro Kamai 2024-09-24 00:53:07 UTC

SUMMARY
On master effects, effect zone alters when I toggle the "Use effect zone" button.

STEPS TO REPRODUCE
1. Make a project with a brief video clip (3840x2160, 30fps in my case)
2. Press "Master" button to open master effect tab.
3. Add the "Fade out" effect
4. Press the "Use effect zone" button to show the effect zone.
5. Set the "In" and "Out" (e.g. 00:00:03:01 and 00:00:04:10)
6. Press the "Use effect zone" 2 times to make the effect zone hidden and shown again

OBSERVED RESULT
"In" time and "Out" time altered. In above case, I see 00:00:04:10 and 00:00:07:10.

EXPECTED RESULT
"In" time and "Out" time would be restored as I set (00:00:03:01 and 00:00:04:10)

SOFTWARE/OS VERSIONS
Windows: Windows 11 Home 23H2
macOS: 
(available in the Info Center app, or by running `kinfo` in a terminal window)
Linux/KDE Plasma: 
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
When the project is reopened, the same problem occurs.

Comment 1 Jean-Baptiste Mardelle 2024-09-24 09:06:13 UTC

Thanks for your report, I can confirm the issue

Comment 2 Jean-Baptiste Mardelle 2024-09-24 09:09:36 UTC

Well in fact this is not a bug. The "Use effect zone" button is not designed to hide/show the effect zone, but to enable/disable the feature.
So "hiding" the effect zone disables the zone, and showing it again enables the feature from the current timeline playhead position.

However I agree this is a bit confusing. Maybe we should rename "Use effect zone" to "Enable effect zone" and "Disable effect zone" when checked ?

Comment 3 Jean-Baptiste Mardelle 2024-09-24 09:11:04 UTC

Also it might be possible to save the last used zone for an effect and restore it when re-enabling it ? This might in fact be the most intuitive solution...

Comment 4 Jean-Baptiste Mardelle 2024-09-24 15:05:56 UTC

Git commit 03d7c867598b5b7f1486d5b33b6f52fc9cba7015 by Jean-Baptiste Mardelle.
Committed on 24/09/2024 at 15:05.
Pushed by mardelle into branch 'master'.

Remember last used zone in effect zone

M  +6    -1    src/effects/effectstack/model/effectitemmodel.cpp
M  +18   -4    src/effects/effectstack/view/collapsibleeffectview.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/03d7c867598b5b7f1486d5b33b6f52fc9cba7015

Comment 5 Bug Janitor Service 2024-10-09 03:47:23 UTC

🐛🧹 ⚠️ This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information, then set the bug status to REPORTED. If there is no change for at least 30 days, it will be automatically closed as RESOLVED WORKSFORME.

For more information about our bug triaging procedures, please read https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging.

Thank you for helping us make KDE software even better for everyone!

Comment 6 Takahiro Kamai 2024-10-09 11:06:31 UTC

This solution is that I wanted. Thank you.