| Summary: | Selecting multiple .desktop files on the desktop causes extreme lag | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | alt |
| Component: | Folder | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | hein, nate |
| Priority: | NOR | ||
| Version: | 6.1.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/f7a92f7e65ac09cfd82a01835ac9f955c1b25744 | Version Fixed In: | 6.3.0 |
| Sentry Crash Report: | |||
| Attachments: | Video of the desktop lagging | ||
|
Description
alt
2024-09-19 17:52:21 UTC
This issue may be related to https://bugs.kde.org/show_bug.cgi?id=489894 (In reply to alt from comment #1) > This issue may be related to https://bugs.kde.org/show_bug.cgi?id=489894 I was able to reproduce this bug too Do any of the apps have large images set as their icons? If so, this is probably another manifestation of Bug 489894. No, they are just ordinary icons, less than 100 kB Hmm, OK. I can't reproduce it, unfortunately. (In reply to Nate Graham from comment #5) > Hmm, OK. I can't reproduce it, unfortunately. I was able to reproduce it on a live USB of Manjaro, but I had to switch to a Wayland session because this issue doesn't happen with X11. I'll add a video as an attachment. Created attachment 173927 [details]
Video of the desktop lagging
Does it still happen in Plasma 6.2? (In reply to Nate Graham from comment #8) > Does it still happen in Plasma 6.2? Yes, still there Can reproduce with over 100 icons on my system. Probably the threshold at which it starts to happen is dependent on the hardware, and maybe secondarily the contents or mimetypes of the icons. Should be fixed with https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2628. Git commit f7a92f7e65ac09cfd82a01835ac9f955c1b25744 by Akseli Lahtinen. Committed on 13/11/2024 at 12:51. Pushed by akselmo into branch 'master'. FolderView: Performance improvements for selections This MR has multiple changes, especially related to the "rubberband" (selection rectangle). - Use `Qt.callLater` for `gridView.rectangleSelect` to eliminate redundant calls. - This was previously called *every time mouse moved one pixel* - Clear a redundant mapToItem - `var cPos = mapToItem(gridView.contentItem, mouse.x, mouse.y);` needs to be only called during rubberband action - Update dragItem images after selection is done, instead of every time a delegate is selected - Instead of creating and destroying `selectionButton` in `FolderItemDelegate`, create it once and toggle its visibility These all should help with the performance related to selecting multiple icons by dragging the selectiong rectangle around them. M +13 -17 containments/desktop/package/contents/ui/FolderItemDelegate.qml M +26 -9 containments/desktop/package/contents/ui/FolderView.qml M +5 -0 containments/desktop/plugins/folder/foldermodel.cpp M +1 -0 containments/desktop/plugins/folder/foldermodel.h https://invent.kde.org/plasma/plasma-desktop/-/commit/f7a92f7e65ac09cfd82a01835ac9f955c1b25744 |