Bug 493359

Summary: Filter offset with locked filter gets applied incorrectly
Product: [Applications] kstars Reporter: Konstantin Baranov <const>
Component: generalAssignee: John Evans <john.e.evans.email>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: git   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Konstantin Baranov 2024-09-19 13:14:26 UTC 
Git master build on Ubuntu 22.04.

1. Have a FW with filters configured as follows:
 - R has offset 0, not locked
 - O has offset 500, locked to R
 - all others also locked to R
2. Align module has filter set to R
3. Focus module also has filter set to R
4. Have a job in the Scheduler with Track, Align, Focus, Guide enabled and a simple sequence of O captures.

I expect Focus to select R filter, run AF. Found solution should be used during Align. Capture should at some point select O filter with shift focus 500 steps out.

What actually happens:
1. Focus runs AF with R.
2. Align shifts focus 500 steps in, as if the filter was set to O! Align is run successfully with R filter, even though slightly out of focus.
3. Guide is successfully initiated with OAG sitting before filter wheel.
4. Capture shifts focus 500 steps out. Incidentally, that is back exactly to the position found for R, not for O. Runs with O filter, which is out of focus now!
Comment 1 Konstantin Baranov 2024-09-19 23:28:38 UTC 
Unlocking the O filter makes everything working fine: AF runs with O, Align runs with R with properly shifted focus, Capture runs with O again with focus shifted back to proper O position. Naturally, AF has harder time with O filter and fails more easily.
Comment 2 John Evans 2024-09-20 11:17:35 UTC 
Thanks for the detailed bug report Konstantin. I just reproduced this on the Simulators... so now to find the cause.
Comment 3 John Evans 2024-09-20 18:45:21 UTC 
Hi Konstantin,

MR!1325 fixes this issue on the Sims. Are you able to take Merge Requests and test?

https://invent.kde.org/education/kstars/-/merge_requests/1325

Regards,
John.
Comment 4 Konstantin Baranov 2024-09-21 07:41:27 UTC 
(In reply to John Evans from comment #3)
> Hi Konstantin,
> 
> MR!1325 fixes this issue on the Sims. Are you able to take Merge Requests
> and test?
> 
> https://invent.kde.org/education/kstars/-/merge_requests/1325
> 
> Regards,
> John.

Yes, will do. Next night should be clear.
Comment 5 Konstantin Baranov 2024-09-22 03:44:33 UTC 
(In reply to John Evans from comment #3)
> Hi Konstantin,
> 
> MR!1325 fixes this issue on the Sims. Are you able to take Merge Requests
> and test?
> 
> https://invent.kde.org/education/kstars/-/merge_requests/1325
> 
> Regards,
> John.

With this change, it worked OK in the original scenario!
Comment 6 John Evans 2024-09-22 06:13:59 UTC 
Great, I'll merge the MR.