Bug 493340

Summary:	holiday dates are not aligned
Product:	[Plasma] plasmashell	Reporter:	tusooa <tusooa>
Component:	Digital Clock	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	minor	CC:	nate
Priority:	NOR
Version:	master
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/-/commit/f345714cdaa6df15057fa2d38052773de2094247	Version Fixed In:	6.2.0
Sentry Crash Report:
Attachments:	dates are not aligned

Description tusooa 2024-09-18 23:32:19 UTC

Created attachment 173846 [details]
dates are not aligned

***
If you're not sure this is actually a bug, instead post about it at https://discuss.kde.org

If you're reporting a crash, attach a backtrace with debug symbols; see https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports

Please remove this comment after reading and before submitting - thanks!
***

SUMMARY
Dates which are holidays (have the holiday names under it) are not aligned vertically with other dates.

STEPS TO REPRODUCE
1. Create a digital clock widget.
2. Configure it in Calendar -> Available Plugins -> Select "Holidays."
3. Open the calendar view and go to a month with a holiday.

OBSERVED RESULT
The dates for holidays are not aligned with other dates.

EXPECTED RESULT
They should align.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
(available in the Info Center app, or by running `kinfo` in a terminal window)
Linux/KDE Plasma: 6.6.38 / master
KDE Plasma Version: master
KDE Frameworks Version: 6.6.0
Qt Version: 6.7.2

ADDITIONAL INFORMATION

Comment 1 Bug Janitor Service 2024-09-19 01:14:22 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4723

Comment 2 Bug Janitor Service 2024-09-19 01:14:23 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4723

Comment 3 Nate Graham 2024-09-24 15:25:41 UTC

Git commit 1e5b9b3d09619dd9eb03e4e7d53560d8246af707 by Nate Graham, on behalf of Tusooa Windy.
Committed on 24/09/2024 at 15:25.
Pushed by ngraham into branch 'master'.

Align dates in calendar view
Before, the dates in the calendar view with a sub-day label are not
vertically aligned with those without it. This fixes the problem,
while keeping the main date label vertically aligned. As a compromise,
the sub-day label may display in a smaller font size due to the size
constraints. It still strives to be as large as before if the vertical
space permits.
FIXED-IN: 6.3.0

M  +28   -17   components/calendar/qml/DayDelegate.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/1e5b9b3d09619dd9eb03e4e7d53560d8246af707

Comment 4 Nate Graham 2024-09-25 19:05:02 UTC

Git commit f345714cdaa6df15057fa2d38052773de2094247 by Nate Graham.
Committed on 25/09/2024 at 19:04.
Pushed by ngraham into branch 'Plasma/6.2'.

Align dates in calendar view
Before, the dates in the calendar view with a sub-day label are not
vertically aligned with those without it. This fixes the problem,
while keeping the main date label vertically aligned. As a compromise,
the sub-day label may display in a smaller font size due to the size
constraints. It still strives to be as large as before if the vertical
space permits.
FIXED-IN: 6.3.0


(cherry picked from commit 1e5b9b3d09619dd9eb03e4e7d53560d8246af707)

ad632e76 Align dates in calendar view

Co-authored-by: Tusooa Windy <tusooa@kazv.moe>

M  +28   -17   components/calendar/qml/DayDelegate.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/f345714cdaa6df15057fa2d38052773de2094247