Bug 493177

Summary:	"Warnings" about and from shellcheck
Product:	[Applications] konsole	Reporter:	ratijas <me>
Component:	plugins	Assignee:	Konsole Developer <konsole-devel>
Status:	CONFIRMED ---
Severity:	normal	CC:	justin
Priority:	NOR
Version:	24.08.1
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	attachment-2093445-0.html

Description ratijas 2024-09-15 22:41:47 UTC

SUMMARY
Annoying warnings of shellcheck make Quick Commands unusable. Entirely bailing out and stop working is not what warnings usually do anyway.

STEPS TO REPRODUCE
1. Save a command like `cd abc; echo xyz` as a Quick Command.
2. Attempt to run it by double-clicking it in the tree view of persisted commands.

OBSERVED RESULT
At first, it complains that shellcheck is not installed and refuses to run the script.

After installing the shellcheck and its ton of haskell dependencies, it complains that `cd` should have `|| return` or `|| exit` (none of which makes sense for a terminal session) and refuses to run the script.

Can it maybe just shut up about those warnings and run my thing anyway? I clicked to run it, not to lint/build/compile a bash script; and I know for sure that my specific directory always exists (or else I have bigger problems to worry about).

EXPECTED RESULT
Warnings aren't critical errors.

I expect that if I saved a command as a "Quick Command" then it should be quick to execute it. Copy pasting it to circumvent the errowarnings is actually slower than using some zsh history search plugin.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.1.5
KDE Frameworks Version: 6.5.0
Qt Version: 6.7.2

ADDITIONAL INFORMATION

Comment 1 tcanabrava 2024-09-16 06:59:56 UTC

Created attachment 173715 [details]
attachment-2093445-0.html

yeah, ill keep the warnings but stop refusing to run.
it will be fixed by next version.

On Sun, 15 Sep 2024 at 23:41 ratijas <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=493177
>
>             Bug ID: 493177
>            Summary: "Warnings" about and from shellcheck
>     Classification: Applications
>            Product: konsole
>            Version: 24.08.1
>           Platform: Other
>                 OS: Linux
>             Status: REPORTED
>           Severity: normal
>           Priority: NOR
>          Component: plugins
>           Assignee: konsole-devel@kde.org
>           Reporter: me@ratijas.tk
>   Target Milestone: ---
>
> SUMMARY
> Annoying warnings of shellcheck make Quick Commands unusable. Entirely
> bailing
> out and stop working is not what warnings usually do anyway.
>
> STEPS TO REPRODUCE
> 1. Save a command like `cd abc; echo xyz` as a Quick Command.
> 2. Attempt to run it by double-clicking it in the tree view of persisted
> commands.
>
> OBSERVED RESULT
> At first, it complains that shellcheck is not installed and refuses to run
> the
> script.
>
> After installing the shellcheck and its ton of haskell dependencies, it
> complains that `cd` should have `|| return` or `|| exit` (none of which
> makes
> sense for a terminal session) and refuses to run the script.
>
> Can it maybe just shut up about those warnings and run my thing anyway? I
> clicked to run it, not to lint/build/compile a bash script; and I know for
> sure
> that my specific directory always exists (or else I have bigger problems to
> worry about).
>
> EXPECTED RESULT
> Warnings aren't critical errors.
>
> I expect that if I saved a command as a "Quick Command" then it should be
> quick
> to execute it. Copy pasting it to circumvent the errowarnings is actually
> slower than using some zsh history search plugin.
>
> SOFTWARE/OS VERSIONS
> Operating System: Arch Linux
> KDE Plasma Version: 6.1.5
> KDE Frameworks Version: 6.5.0
> Qt Version: 6.7.2
>
> ADDITIONAL INFORMATION
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.