Bug 492972

Summary: Elisa incorrectly reports remaining tracks and time if the playlist was not started yet
Product: [Applications] Elisa Reporter: cwo <cwo.kde>
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: CONFIRMED ---    
Severity: normal CC: jackhill3103
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description cwo 2024-09-11 08:37:19 UTC 
SUMMARY

Elisa's playlist has a footer that indicates the total number of tracks, the total runtime, as well as the remaining tracks and runtime. The number of remaining tracks reasonably does not include the currently playing track, and the remaining time even more reasonably does not include the time that the currently playing track has played.

Less reasonably though, the currently loaded track is also excluded if it hasn't started playing yet, and with some trickery the same is true for the remaining time; using a somewhat convoluted method it is possible to get the remaining time to vanish completely (I assume because the remaining duration is negative). 

STEPS TO REPRODUCE

Simple case for remaining tracks:

1. Add an album to the playlist then clear the playlist
2. Add another album
3. Note the remaining tracks and remaining time

Convoluted case for remaining duration:

1. Load a track with a very long runtime (e.g. unsplit mixtape), play it until it is close to over (or just move the slider), then pause
2. Close Elisa, then reopen it
3. Clear the playlist, and add a short album (for best effect, choose an album that is shorter than the play position of the track from 1)

(Clearing the playlist resets the position if a track was played, but not the position loaded on startup)

OBSERVED RESULT

Simple case above: "5/6 tracks remaining, 36:28 remaining, 36:28 total"

Convoluted case: "5/6 tracks remaining,[empty space] remaining, 36:28 total"

(if the previous track duration is not longer than the loaded album duration, replace [empty space] with total duration - previous track duration)

EXPECTED RESULT

Both cases:

"6/6 tracks remaining, 36:28 remaining, 36:28 total"

SOFTWARE/OS VERSIONS
KDE Plasma Version: 6.1.80 (kde-built a day or so ago)
KDE Frameworks Version:  6.7.0 (same)
Qt Version: 6.7.2

Elisa git master
Comment 1 Jack Hill 2024-09-11 20:18:37 UTC 
I couldn't reproduce the first case (unless I'm misunderstanding the issue).

I can reproduce the second case, but I also noticed that it's easier to reproduce by just enqueuing everything from the tracks view. I got "1,097 / 1,098 tracks remaining,  remaining,  total"
Comment 2 cwo 2024-09-11 20:56:38 UTC 
(In reply to Jack Hill from comment #1)
> I couldn't reproduce the first case (unless I'm misunderstanding the issue).
> 
> I can reproduce the second case, but I also noticed that it's easier to
> reproduce by just enqueuing everything from the tracks view. I got "1,097 /
> 1,098 tracks remaining,  remaining,  total"

The first issue is just that when I make a new playlist with an album with, say, 14 tracks and haven't started playing it yet (so add to playlist, not add to playlist and immediately play) it should say "14 tracks remaining" because when I hit play, 14 tracks will play completely, not 13 (as Elisa says right now). When I hit play, it can immediately say "13 tracks remaining" because it makes sense not to count the track that's playing right now as a "remaining track" because some of it has already played, but if I haven't started playing it yet, it's still a full remaining track.

(Similarly if the playlist is finished, or if I start Elisa)

It's possible that the second issue also happens the same way, it's a bit awkward for me to test because my library has 40k+ tracks and Elisa doesn't like adding that many to a playlist at once.