Summary: | Mount point not correctly created in .desktop file for CD-ROM devices | ||
---|---|---|---|
Product: | [Unmaintained] kio | Reporter: | David C Maurer <david.c.maurer> |
Component: | devices | Assignee: | David Faure <faure> |
Status: | RESOLVED NOT A BUG | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
David C Maurer
2002-10-17 18:13:17 UTC
Addressing the first bug here: "MountPoint missing by default", I can report "works for me", on a system was installed as KDE 3.0.4 from the Knoppix Debian Linux 3.1 CD. However, I can confirm the second issue "no way to edit mount point for custom mount devices". I found no way to specify the mount point besides busting out the command line. Mark Subject: Re: New: Mount point not correctly created in .desktop file for CD-ROM devices On Thursday 17 October 2002 18:13, David C Maurer wrote: > The default CD/DVD-ROM Device .desktop entry created by default on KDE 3.0.3 > install or first-run does not create the correct mount point entry. Ah, this must be the kio_devices stuff then. I'll reassign once the question below is resolved. > This bug also shows up when right clicking on the desktop to create a new CD/DVD-ROM Device. > The new properties window under the device tab has a dropdown box to type in the /dev/ name of the device, > but no dropdown or entry box to type in or select the mount point. > I'm assuming the tool is supposed to read the mount point from /etc/fstab when the device name is entered. > But it's not updating the mount point field when a /dev/ entry is manually typed in. Hmm, indeed. Fixed. > Only when selecting a device from the dropdown list will the mount point be updated correctly. > The option to edit the mount point or the ability to manually enter the mount point should exist in the device tab window. I thought that only root was allowed to mount an arbitrary device onto an arbitrary mountpoint? A user can only do this if the "user" option exists in fstab, so the entry needs to be in fstab in the first place, right? Or is this different on some systems? Subject: kdelibs/kio/kfile CVS commit by faure: Update mountpoint label when device is changed with keyboard CCMAIL: 49293@bugs.kde.org M +14 -0 kpropertiesdialog.cpp 1.289 M +1 -0 kpropertiesdialog.h 1.100 --- kdelibs/kio/kfile/kpropertiesdialog.cpp #1.288:1.289 @@ -2642,4 +2642,7 @@ KDevicePropsPlugin::KDevicePropsPlugin( connect( unmounted, SIGNAL( iconChanged( QString ) ), this, SIGNAL( changed() ) ); + + connect( device, SIGNAL( textChanged( const QString & ) ), + this, SLOT( slotDeviceChanged() ) ); } @@ -2656,8 +2659,19 @@ KDevicePropsPlugin::~KDevicePropsPlugin( void KDevicePropsPlugin::slotActivated( int index ) { + // Update mountpoint so that it matches the device that was selected in the combo device->setEditText( m_devicelist[index] ); mountpoint->setText( d->mountpointlist[index] ); } +void KDevicePropsPlugin::slotDeviceChanged() +{ + // Update mountpoint so that it matches the typed device + int index = m_devicelist.findIndex( device->currentText() ); + if ( index != -1 ) + mountpoint->setText( d->mountpointlist[index] ); + else + mountpoint->setText( QString::null ); +} + bool KDevicePropsPlugin::supports( KFileItemList _items ) { --- kdelibs/kio/kfile/kpropertiesdialog.h #1.99:1.100 @@ -636,4 +636,5 @@ public: private slots: void slotActivated( int ); + void slotDeviceChanged(); private: yes, only root is allowed to mount arbitrary devices at arbitrary mountpounts. So, in order for a user to mount the drive, it'd have to be in fstab anyway with the user option and AFAIK it works this way on all systems. Perhaps it's time for that reassignment to kio_devices... KDE 3.4 has no default CD-ROM Icon installed. The other mentioned problem (manual entering) was fixed long ago. Also, in 3.4 the devices:/ ioslave no longer exists and was replaced with media:/ |