Bug 492860

Summary: plasmashell loop-hangs on comic-popup-button click with commit bd4e3d920b103647155cc9b2ee8ebb7676e654e4
Product: [Unmaintained] kdeplasma-addons Reporter: Duncan <1i5t5.duncan>
Component: ComicAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: cwo.kde, nate
Priority: NOR    
Version First Reported In: git-master   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: All   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Duncan 2024-09-09 05:18:14 UTC
[live-git master frameworks/plasma/most-gear from the gentoo/kde overlay]

This (despammed emails):

commit bd4e3d920b103647155cc9b2ee8ebb7676e654e4
Author:     Christoph Wolk <christoph.wolk@>
AuthorDate: Mon Sep 2 16:34:50 2024 +0200
Commit:     Nate Graham <nate@>
CommitDate: Tue Sep 3 17:57:06 2024 +0000

     applets/comic: enforce minimum FullViewWidget size

... may or may not have fixed the no-image case, but it definitely broke the image-there case in the same way it was intended to fix the no-image case -- loop-hung plasmashell.

The (looping) error when running plasmashell from konsole:

file:///share/plasma/plasmoids/org.kde.plasma.comic/contents/ui/FullViewWidget.qml:36:15: QML ScrollView: Possible anchor loop detected on fill.

(Yes that is an absolute path starting at /share/.  Reverse-usrmerge /usr -> . so it's obviously printing the symlink-resolved path .)

I have tiny comic thumbnails in a panel (small autohide), relying on the comic-popup button to display them at normal size, so I use the button daily.  With that commit applied when I try to do so I get a loop-hung plasmashell. =:^(

Fortunately I track the git logs and remembered seeing this commit in my pre-update read-thru.  Applying a reverting patch, rebuilding and restarting plasmashell quickly got my comics back working again, confirming  the culprit. =:^)
Comment 1 Duncan 2024-09-09 05:21:10 UTC
CCing author and committer.
Comment 2 cwo 2024-09-09 06:32:51 UTC
Hm, can reproduce. Weird, it worked when I tried it before submitting the MR. Anyway, confirming, will investigate later today.
Comment 3 Bug Janitor Service 2024-09-09 13:12:53 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/623
Comment 4 cwo 2024-09-09 22:19:59 UTC
Git commit 9129026bf195516e23b9a75417d8aca8cbb44051 by Christoph Wolk.
Committed on 09/09/2024 at 13:11.
Pushed by ngraham into branch 'master'.

applets/comic: import Kirigami in FullViewWidget

The FullViewWidget uses Kirigami.Unit, but does not import Kirigami.

This change adds Kirigami to the imports.

M  +1    -0    applets/comic/package/contents/ui/FullViewWidget.qml

https://invent.kde.org/plasma/kdeplasma-addons/-/commit/9129026bf195516e23b9a75417d8aca8cbb44051