Bug 492717

Summary: Widgets' context menus contain checkboxes that track temporary state, but look like settings
Product: [Plasma] plasmashell Reporter: Cherkah <cherkaba>
Component: Show Desktop/Minimize AllAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: minor CC: cherkaba, nate
Priority: NOR Keywords: usability
Version: 6.1.4   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/1e2fb8865e02190c39797a503f593bcf80fdd4ca Version Fixed In: 6.2.0
Sentry Crash Report:
Attachments: non-persistent settings

Description Cherkah 2024-09-06 14:02:53 UTC 
SUMMARY
the  show-desktop 's settings in systemsettings are persistent unlike to the plasmoide ones
see the video screenrecord

STEPS TO REPRODUCE
1. change the settings of the show-desktop/minimize-all plasmoid 
2. minimize all your apps then show your desktop 
3. the setting went away

OBSERVED RESULT
the settings are not persistent unlike the parameters defined via the systemSettings window

EXPECTED RESULT
the settings have to be persistent

SOFTWARE/OS VERSIONS
Operating System: EndeavourOS 
KDE Plasma Version: 6.1.4
KDE Frameworks Version: 6.5.0
Qt Version: 6.7.2
Kernel Version: 6.10.8-arch1-1 (64-bit)
Graphics Platform: Wayland
Comment 1 Cherkah 2024-09-06 15:15:09 UTC 
Created attachment 173385 [details]
non-persistent settings
Comment 2 Nate Graham 2024-09-07 07:48:56 UTC 
Those checkboxes are not settings, they are just temporary state.

I guess we could replace them with non-checkable menu items that change name depending on the current state, which might help to avoid them looking like settings.
Comment 3 Bug Janitor Service 2024-09-11 17:47:12 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2514
Comment 4 cwo 2024-09-11 20:02:23 UTC 
Git commit 1e2fb8865e02190c39797a503f593bcf80fdd4ca by Christoph Wolk.
Committed on 11/09/2024 at 17:40.
Pushed by ngraham into branch 'master'.

applets/showdesktop: vary labels instead of checkbox

The Peek at Desktop and Minimize All Windows applets have context menu
entries that allow accessing either function; they currently use
checkable menu entries. This makes the entries look like settings,
rather than actions the user can trigger, leading to confusion.

This change removes the checkable property and instead uses the already
existing action labels as the context menu entries. Icons are also set
to fill the space previously used by the checkboxes.

M  +4    -6    applets/showdesktop/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/1e2fb8865e02190c39797a503f593bcf80fdd4ca