Bug 492697

Summary:	Marker created from Project Note is created at 00:00:00:00 instead of what the timecode is in the note
Product:	[Applications] kdenlive	Reporter:	Bernd <berndmj>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	24.08.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/multimedia/kdenlive/-/commit/69950f0c64d71bbd34bf069125b03926c47b7f6f	Version Fixed/Implemented In:
Sentry Crash Report:

Description Bernd 2024-09-05 22:24:00 UTC

SUMMARY
When creating annotations (aka Project Notes) the timeline position of the playhead is copied into the project note. This timestamp can be selected and a marker created from it. However, regardless of what the timestamp says the marker is created at the beginning of the project (00:00:00:00).

STEPS TO REPRODUCE
1. Put a clip into the timeline
2. Move the playhead to an arbitrary position and create a project note
3. Select the project note and use the "Create marker from selected notes"

OBSERVED RESULT
A marker is created at 00:00:00:00 (beginning of the project)

EXPECTED RESULT
A marker is created at the position indicated in the note

SOFTWARE/OS VERSIONS
Linux/: Pop!_OS 22.04
KDE Frameworks Version: 6.5
Qt Version: 6.7.2

Comment 1 Jean-Baptiste Mardelle 2024-09-06 10:46:42 UTC

Git commit a6bb266ec33ed56476c2d6d5e1dc7427285e5ac4 by Jean-Baptiste Mardelle.
Committed on 06/09/2024 at 10:46.
Pushed by mardelle into branch 'master'.

Fix adding marker from project notes always adds it at 00:00

M  +16   -7    src/core.cpp
M  +1    -1    src/core.h
M  +16   -5    src/project/dialogs/noteswidget.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/a6bb266ec33ed56476c2d6d5e1dc7427285e5ac4

Comment 2 Jean-Baptiste Mardelle 2024-09-06 12:44:39 UTC

Git commit e61520c2e0dd2078761d0e72b6de34b69338df3c by Jean-Baptiste Mardelle.
Committed on 06/09/2024 at 12:43.
Pushed by mardelle into branch 'release/24.08'.

Fix adding marker from project notes always adds it at 00:00

M  +16   -7    src/core.cpp
M  +1    -1    src/core.h
M  +16   -5    src/project/dialogs/noteswidget.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/e61520c2e0dd2078761d0e72b6de34b69338df3c

Comment 3 Bernd 2024-09-06 18:54:30 UTC

I can confirm it works now. Thanks, JBM!

Comment 4 Bernd 2024-09-08 00:08:01 UTC

The feature "Reassign selected timecodes to current bin clip" only creates a marker at position "00:00:00:00" of the current bin clip not taking the timecode into account. The bin clip name is correctly brought into the note.

Comment 5 Jean-Baptiste Mardelle 2024-09-09 18:28:12 UTC

Git commit 69950f0c64d71bbd34bf069125b03926c47b7f6f by Jean-Baptiste Mardelle.
Committed on 09/09/2024 at 18:28.
Pushed by mardelle into branch 'release/24.08'.

Fix reassigning timecode to project clip

M  +7    -1    src/project/notesplugin.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/69950f0c64d71bbd34bf069125b03926c47b7f6f