Bug 492654

Summary:	In the settings dialog of system monitor widgets, the pages do not scroll if contents are larger than window
Product:	[Plasma] plasmashell	Reporter:	cwo <cwo.kde>
Component:	System Monitor	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ahiemstra, kdedev, nate, notmart
Priority:	NOR
Version:	master
Target Milestone:	1.0
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=489580 https://bugs.kde.org/show_bug.cgi?id=482413
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/-/commit/1ae61b267293f4ee950b133cd2d222590ec757c3	Version Fixed In:	6.2.1
Sentry Crash Report:

Description cwo 2024-09-04 15:24:25 UTC

SUMMARY

The settings dialog for system monitor widgets contains three pages that are specific to these applets, namely Appearance, the face configuration, and the sensor configuration, in addition to the standard Keyboard Shortcuts and About pages. In usual widget configuration dialogs, the contents of the pages are put into ScrollViews so that they can be accessed even if the contents are too large for the available space. This does work for About here, but is broken for the three main pages. I suspect this is because the contentItem of the SimpleKCM is reset, bypassing the usual ScrollView from SimpleKCM (through Kirigami.ScrollablePage).  


STEPS TO REPRODUCE
1. Add a system monitor widget (e.g. Total CPU Use), right-click > Configure Total CPU Use…
2. Resize the dialog to be as small as possible, select display style "Grid", apply, and move to the Grid Details page 
3. Select Line Chart (or another face with lots of options)

OBSERVED RESULT

Many options are not visible, with no indication that they exist (no Scrollbar, scrolling with the wheel does nothing, tab-navigation works but still does not show the entries...)

EXPECTED RESULT

A scroll bar is shown. 

SOFTWARE/OS VERSIONS
KDE Plasma Version: git master from yesterday, also happens on current Fedora in a VM
KDE Frameworks Version: git master from yesterday 
Qt Version: 6.7.2

Comment 1 TraceyC 2024-09-04 19:25:47 UTC

I can confirm this on git-master as well as 6.1.4

Comment 2 Nate Graham 2024-09-05 19:02:27 UTC

Quite possibly the same issue as Bug 482413 or Bug 489580, or both.

Comment 3 Bug Janitor Service 2024-10-04 13:25:40 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4790

Comment 4 Arjen Hiemstra 2024-10-09 14:20:54 UTC

Git commit 168fac064fcf924d33da0368d2af0ec45d6a4d55 by Arjen Hiemstra.
Committed on 09/10/2024 at 13:52.
Pushed by ahiemstra into branch 'master'.

applets/sysmon: Don't override contentItem of ScrollablePage in config ui

Overriding the contentItem breaks scrollable page and causes things to
not actually scroll.

M  +22   -3    applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigAppearance.qml
M  +22   -3    applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigSensors.qml
M  +22   -3    applets/systemmonitor/systemmonitor/package/contents/ui/config/FaceDetails.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/168fac064fcf924d33da0368d2af0ec45d6a4d55

Comment 5 Arjen Hiemstra 2024-10-10 16:57:59 UTC

Git commit 1ae61b267293f4ee950b133cd2d222590ec757c3 by Arjen Hiemstra.
Committed on 10/10/2024 at 16:38.
Pushed by ahiemstra into branch 'Plasma/6.2'.

applets/sysmon: Don't override contentItem of ScrollablePage in config ui

Overriding the contentItem breaks scrollable page and causes things to
not actually scroll.


(cherry picked from commit 168fac064fcf924d33da0368d2af0ec45d6a4d55)

Co-authored-by: Arjen Hiemstra <ahiemstra@heimr.nl>

M  +22   -3    applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigAppearance.qml
M  +22   -3    applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigSensors.qml
M  +22   -3    applets/systemmonitor/systemmonitor/package/contents/ui/config/FaceDetails.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/1ae61b267293f4ee950b133cd2d222590ec757c3