Bug 492652

Summary:	Broken application layout when adding a new timer
Product:	[Applications] KClock	Reporter:	Marc <marc.ferland>
Component:	General	Assignee:	Devin Lin <espidev>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hanyoung
Priority:	NOR
Version First Reported In:	24.08.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/utilities/kclock/-/commit/a05b74f673f96c3ec734539922b3b57d0477d5b8	Version Fixed/Implemented In:	24.12
Sentry Crash Report:
Attachments:	New timer screenshot

Description Marc 2024-09-04 13:14:22 UTC

***
If you're not sure this is actually a bug, instead post about it at https://discuss.kde.org

If you're reporting a crash, attach a backtrace with debug symbols; see https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

SUMMARY
The layout used when adding a new timer in KClock is broken (see attached screenshot). Note that I am using a resolution of 1920x1080.

STEPS TO REPRODUCE
1. Open the KClock application
2. Click "New timer"

OBSERVED RESULT
It is as if the layout is shifted to the left.

EXPECTED RESULT
I would expect the same behavior as when we click on   "Add Alarm".

SOFTWARE/OS VERSIONS
Linux: 6.1.68 
KDE Plasma Version: 6.1.4
KDE Frameworks Version: 6.5.0
Qt Version: 6.7.3

Comment 1 Marc 2024-09-04 13:14:47 UTC

Created attachment 173323 [details]
New timer screenshot

Comment 2 Bug Janitor Service 2024-09-29 23:46:59 UTC

A possibly relevant merge request was started @ https://invent.kde.org/utilities/kclock/-/merge_requests/136

Comment 3 Devin Lin 2024-09-30 00:35:01 UTC

Git commit a05b74f673f96c3ec734539922b3b57d0477d5b8 by Devin Lin.
Committed on 29/09/2024 at 23:59.
Pushed by devinlin into branch 'master'.

Remove new timer drawer for mobile and use dialog

OverlayDrawer has caused problems on wider displays as it seems to
always open improperly. Simplify the code by just using the dialog
implementation for desktop.

A  +78   -0    src/kclock/qml/timer/TimerFormDialog.qml     [License: GPL(v2.0+)]
D  +0    -153  src/kclock/qml/timer/TimerFormWrapper.qml
M  +2    -4    src/kclock/qml/timer/TimerListPage.qml
M  +9    -9    src/kclock/resources.qrc

https://invent.kde.org/utilities/kclock/-/commit/a05b74f673f96c3ec734539922b3b57d0477d5b8