| Summary: | Splash screen installed from KDE Store is not available for selection until the KCM is reopened | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Patrick Silva <bugseforuns> |
| Component: | kcm_splashscreen | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | nate |
| Priority: | NOR | ||
| Version: | 6.1.4 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kpackage/-/commit/cdf14b11ef914e3304b0171b91a61c2388d0b7ee | Version Fixed In: | 6.2.0 |
| Sentry Crash Report: | |||
|
Description
Patrick Silva
2024-09-02 19:09:04 UTC
Can mostly reproduce. What I actually see is that a new entry gets created in the KCM immediately, but it's a duplicate of "Breeze". Leaving the KCM and coming back restores it to its true form. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kpackage/-/merge_requests/98 A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/335 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2535 Git commit d3953a0220a571dcb84239bc21bbd93d062ed47e by David Edmundson, on behalf of Marco Martin. Committed on 27/09/2024 at 07:59. Pushed by davidedmundson into branch 'master'. kcms/ksplash: Correctly remove entries when uninstalled via kns QFileInfo::fileName() is empty if the path ends with a /, manage the case when entry.installedFiles() is adirectory depends on https://invent.kde.org/frameworks/kpackage/-/merge_requests/98 and https://invent.kde.org/frameworks/knewstuff/-/merge_requests/335 M +2 -1 kcms/ksplash/kcm.cpp https://invent.kde.org/plasma/plasma-desktop/-/commit/d3953a0220a571dcb84239bc21bbd93d062ed47e A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2556 Git commit 7e2e5087921b882365ce903b4e2f7caf18147545 by David Edmundson, on behalf of David Edmundson. Committed on 27/09/2024 at 08:11. Pushed by davidedmundson into branch 'Plasma/6.2'. kcms/ksplash: Correctly remove entries when uninstalled via kns QFileInfo::fileName() is empty if the path ends with a /, manage the case when entry.installedFiles() is adirectory depends on https://invent.kde.org/frameworks/kpackage/-/merge_requests/98 and https://invent.kde.org/frameworks/knewstuff/-/merge_requests/335 (cherry picked from commit d3953a0220a571dcb84239bc21bbd93d062ed47e) 6875fde4 Correctly remove entries when uninstalled via kns Co-authored-by: Marco Martin <notmart@gmail.com> M +2 -1 kcms/ksplash/kcm.cpp https://invent.kde.org/plasma/plasma-desktop/-/commit/7e2e5087921b882365ce903b4e2f7caf18147545 Git commit cdf14b11ef914e3304b0171b91a61c2388d0b7ee by Marco Martin. Committed on 27/09/2024 at 15:08. Pushed by mart into branch 'master'. Don't double emit emitResult() setupNotificationsOnJobFinished connects to jobThreadFinished and in there emitResult() is called, so avoid a second connection that would lead to a double emitted signal. connect to installPathChanged before connecting to jobThreadFinished. Signal order matters here, as some client code relies that the package path() to already be the final "correct" one when the job finishes together with https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2535 M +6 -6 src/kpackage/packagejob.cpp https://invent.kde.org/frameworks/kpackage/-/commit/cdf14b11ef914e3304b0171b91a61c2388d0b7ee Git commit 1210fa8c0cea78737467c40e8439b1d51f2778b5 by Marco Martin. Committed on 27/09/2024 at 15:17. Pushed by mart into branch 'master'. Don't emit twice slotEntryChanged Don't connect KNSCore::Installation::signalEntryChanged as is already forwarded to Transaction, which in turn is forwarded to our slotEntryChanged, so avoids a double emission This fixes double entries created after installing something with KNS depends on https://invent.kde.org/frameworks/kpackage/-/merge_requests/98 M +58 -0 autotests/core/knewstuffenginetest.cpp M +1 -0 src/core/transaction.cpp M +2 -1 src/qtquick/quickengine.cpp https://invent.kde.org/frameworks/knewstuff/-/commit/1210fa8c0cea78737467c40e8439b1d51f2778b5 It's still reproducible with the provided steps. Operating System: Arch Linux KDE Plasma Version: 6.2.0 KDE Frameworks Version: 6.6.0 Qt Version: 6.7.3 Graphics Platform: Wayland Cannot reproduce after updating to frameworks 6.7. Operating System: Arch Linux KDE Plasma Version: 6.2.0 KDE Frameworks Version: 6.7.0 Qt Version: 6.7.3 Graphics Platform: Wayland |