| Summary: | Crash on entering text into the collection browser filter | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | robert marshall <robert> |
| Component: | Collection Browser | Assignee: | Amarok Bugs <amarok-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | braggrj, tuomas, web.mseidel |
| Priority: | NOR | ||
| Version First Reported In: | 3.1.0 | ||
| Target Milestone: | kf5 | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/multimedia/amarok/-/commit/e5a0cf63c992f4eaddfba33cd3bd856272b518f8 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
robert marshall
2024-08-30 12:44:35 UTC
Yes, thank you for reporting this! I know there's something like this hiding in there, I've got it on my personal TODO, I have a hunch how to replicate, and this is the most common crash on crash-reports.kde.org too. I believe this is related to some problems with Qt5 port of everything ThreadWeaver related, partially explained in https://mail.kde.org/pipermail/amarok-devel/2015-October/013807.html , and something I have on my list of "try working on after Qt6 port is done". Should be possible to fix, but requires some work, and has a risk of breaking more than fixes, so something I'd figure is more appropriate for 4.0 instead of e.g. 3.1.1. Maybe a common factor - strawberry is also very like to crash when typing in the collection filter - tends to happen when there's a lot of tracks visible - I will experiment and see if that avoids the problem - though I guess the more tracks the more likely it is to trip over the possible double destruction of something (if that threadweaver discussion is apposite) *** Bug 494911 has been marked as a duplicate of this bug. *** I thought I knew how to reproduce this, but apparently I don't. I'll keep trying, but it could be very helpful if someone manages to produce a backtrace with debug symbols installed (so the exact linenumber in Collections::SqlQueryMaker::abortQuery() is visible), or if someone finds out what are the exact steps & conditions to reproduce this I'm not able to reproduce this at will, but I'm tending to see itwhen amarok is about to stop playing - through the use of 'stop playing after this track' I'm seeing if I can build amarok (kubuntu 24.04) I seem to remember a problem at link last time I tried but will see! Reading and testing various things, this is probably still the same bug as back in https://bugs.kde.org/show_bug.cgi?id=431738 and my related fixes then didn't help with this specific crash. A new attempt is available at https://invent.kde.org/multimedia/amarok/-/merge_requests/129 . As I haven't managed to reproduce the crash lately, testing of the merge request is naturally appreciated, but unless anything bad comes up in my own daily usage, I'll merge it to git master in some days and hope that it resolves the issue. I merged the changes just now, so they should appear in nightly builds in a couple of days. Then I guess it's just waiting and seeing if this kind of crash reports still appear with Amarok version 3.1.71-git. *** Bug 495362 has been marked as a duplicate of this bug. *** I'm running 3.1.71-git version of amarok from the kubuntu ppa (passing over my failure to build the latest from git :( ) since 29th Oct and am yet to see a crash whilst changing the filter (or indeed any crash) so I'm hopeful that this is now fixed! Thanks! Okay, thank you for the update! That's very good to hear. I'll keep this report open some more time and close before 3.2.0 release (sometime later this year probably) if all still seems well then. Git commit e5a0cf63c992f4eaddfba33cd3bd856272b518f8 by Tuomas Nurmi. Committed on 06/12/2024 at 08:59. Pushed by nurmi into branch 'master'. Add ChangeLog entry for previous bugfix No documented occurrence of the crash after the changes 1.5 months ago, so it was probably fixed by commit dbc51be0eac3f070a05e65ae1b3693844cb60477 as hoped. M +1 -0 ChangeLog https://invent.kde.org/multimedia/amarok/-/commit/e5a0cf63c992f4eaddfba33cd3bd856272b518f8 |