Bug 492399

Summary:	Feat: Support https:// webseeds
Product:	[Applications] ktorrent	Reporter:	Holger <private_lock>
Component:	general	Assignee:	Joris Guisson <joris.guisson>
Status:	RESOLVED FIXED
Severity:	normal	CC:	justin
Priority:	NOR
Version:	23.08.5
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/network/ktorrent/-/commit/cdb33edc17acea7663660292ef4d857c29573a41	Version Fixed In:
Sentry Crash Report:

Description Holger 2024-08-30 09:43:06 UTC

SUMMARY
Only http:// without S will allow the add Webseed button to enable, so it can be clicked. But nowadays, you won't find http only sources anymore. Usually the downloads are https:// same as the rest of the web.

Force-adding a link by editing the s out form the URL seems not to work, as the resulting webseed is stuck in "resolving host".

STEPS TO REPRODUCE
1. start any Ubuntu torrent from: e.g. https://cdimage.ubuntu.com/kubuntu/releases/noble/release/
2. Copy the direct download URL of the ISO with https://
3. Paste into webseed field (Button disabled)
4. edit into http:// (Button enabled)
5. click add (won't download anything from there)

OBSERVED RESULT
Cannot click "Add Webseed"-button or stuck in "resolving host"

EXPECTED RESULT
Download from https://

SOFTWARE/OS VERSIONS
Operating System: Kubuntu 24.04
KDE Plasma Version: 5.27.11
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.13
Kernel Version: 6.8.0-41-generic (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-4700MQ CPU @ 2.40GHz
Memory: 15.5 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 4600
Manufacturer: Micro-Star International Co., Ltd.
Product Name: GE70 2OC\2OD\2OE
System Version: REV:1.0

ADDITIONAL INFORMATION
mentioned in bug 305432 comment 1

Comment 1 Justin Zobel 2024-08-31 03:50:00 UTC

Confirmed with 24.08.0 from Flathub.

Comment 2 Bug Janitor Service 2024-09-08 16:48:39 UTC

A possibly relevant merge request was started @ https://invent.kde.org/network/libktorrent/-/merge_requests/68

Comment 3 Bug Janitor Service 2024-09-08 16:48:49 UTC

A possibly relevant merge request was started @ https://invent.kde.org/network/ktorrent/-/merge_requests/124

Comment 4 Albert Astals Cid 2024-10-13 11:22:36 UTC

Git commit f268006aede904acc113cca2d8b8f0d2e75486fa by Albert Astals Cid, on behalf of Jack Hill.
Committed on 13/10/2024 at 11:19.
Pushed by aacid into branch 'master'.

Accept HTTPS webseeds too

Tested using the Kubuntu iso given in the linked bug report.

M  +3    -2    ktorrent/dialogs/torrentcreatordlg.cpp
M  +3    -2    plugins/infowidget/webseedstab.cpp

https://invent.kde.org/network/ktorrent/-/commit/f268006aede904acc113cca2d8b8f0d2e75486fa

Comment 5 Albert Astals Cid 2024-10-13 17:56:41 UTC

Git commit cdb33edc17acea7663660292ef4d857c29573a41 by Albert Astals Cid, on behalf of Jack Hill.
Committed on 13/10/2024 at 17:56.
Pushed by aacid into branch 'release/24.08'.

Accept HTTPS webseeds too

Tested using the Kubuntu iso given in the linked bug report.
(cherry picked from commit f268006aede904acc113cca2d8b8f0d2e75486fa)

M  +3    -2    ktorrent/dialogs/torrentcreatordlg.cpp
M  +3    -2    plugins/infowidget/webseedstab.cpp

https://invent.kde.org/network/ktorrent/-/commit/cdb33edc17acea7663660292ef4d857c29573a41

Comment 6 Jack Hill 2024-10-20 13:42:27 UTC

Git commit fcfc12d480ef889fdc28c0992b1cdd9615fea520 by Jack Hill.
Committed on 20/10/2024 at 13:36.
Pushed by jackh into branch 'master'.

Fix loading HTTPS webseeds

M  +4    -2    src/download/downloader.cpp
M  +3    -1    src/download/webseed.cpp

https://invent.kde.org/network/libktorrent/-/commit/fcfc12d480ef889fdc28c0992b1cdd9615fea520